bugFreeciv - Bugs: bug #20898, Terraforming should destroy(hide)...

Show feedback again

bug #20898: Terraforming should destroy(hide) ruins

Submitted by:  Michal Papis <mpapis>
Submitted on:  Fri 14 Jun 2013 12:24:59 AM UTC  
Category: generalSeverity: 1 - Wish
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: 2.3.4Operating System: None
Planned Release: 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Fri 06 Sep 2013 06:40:06 PM UTC, SVN revision 23302:

Added extra flag "TerrChangeRemoves". Given it to Ruins in all rulesets
for Ruins to disappear when ever terrain changes.

Requested by Michal Papis

See bug #20898

(Browse SVN revision 23302)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 03 Sep 2013 10:37:41 AM UTC, comment #2:

Attached patch adds support for extra flag "TerrChangeRemove" and gives it to Ruins in all supplied rulesets.

(file #18843)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 15 Jul 2013 07:35:05 AM UTC, comment #1:

In general bases remain when terrain changes to one where the base can exist. Thus Ruins are destroyed (in classic ruleset) when land is turned in to ocean.
We could introduce extra_type flag indicating that extra in question gets destroyed when ever terrain changes, regardless if target terrain type could have the extra. That would actually be good way to introduce extra_type flags in the first place.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 14 Jun 2013 12:24:59 AM UTC, original submission:
Michal Papis <mpapis>


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #18843:  TerrChangeRemoves.patch added by cazfi (6kB - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by mpapis (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 06 Sep 2013 06:40:18 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
    Tue 03 Sep 2013 10:37:41 AM UTCcazfiAttached File-=>Added TerrChangeRemoves.patch, #18843
      StatusNone=>Ready For Test
      Planned Release=>2.6.0
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup