bugFreeciv - Bugs: bug #20920, [metaticket] freeciv-server...

 
 
Show feedback again

bug #20920: [metaticket] freeciv-server crashes seen on play.freeciv.org

Submitted by:  Andreas Rosdal <andreasr>
Submitted on:  Wed 19 Jun 2013 09:04:21 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: trunkOperating System: GNU/Linux
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 20 Jun 2013 06:53:32 PM UTC, comment #6:

mir3x, the tileset is loaded in Javascript in the user's web-browser, the server side of freeciv-web doesn't load a tileset. So I don't think any of these crashes are tileset related. Do you have any other suggestion about some of these failed assertions?

I should note that these assertions that I have reported here are gathered over quite a long time period, so it's not like the freeciv server is crashing all the time. When thousands of games are played, it's not surprising that it might occasionally crash, for software that is still in development.

Andreas Rosdal <andreasr>
Project Member
Thu 20 Jun 2013 04:12:57 PM UTC, comment #5:

Its just my guess:

Its trying to reread tileset, but earlier none has been loaded or fully initizalized.
( call to function ->
void tilespec_reread(const char *new_tileset_name)
(from tilespec.h)
)

mir3x <mir3x>
Project Member
Thu 20 Jun 2013 05:34:59 AM UTC, comment #4:

There savegame has been deleted, so it's not possible to know which version it is from. Most likely it is from Freeciv trunk revision 22904, though.

I agree that freeciv-web should have a stable and a development branch like freeciv, I just haven't managed to do it yet. Feel free to help with this.

Anyway, these are some of the most frequent crashes: Any idea why they happen?

[plrhand.c::2774]: assertion 'game.server.plr_colors != ((void *)0)' failed.
[plrhand.c::2784]: assertion 'game.server.plr_colors != ((void *)0)' failed.

fcweb-5855.log:1: in dir2char() [savegame2.c::984]: assertion 'FALSE' failed.

Andreas Rosdal <andreasr>
Project Member
Wed 19 Jun 2013 10:02:11 PM UTC, comment #3:

Could it be simply matter of savegame been originally written with freeciv trunk version after S2_5 branching (format version number of 2.6 development version) but before extras owner information was added to the format?
Then this would be just what you get for insisting to use unstable (development) formats and APIs in freeciv-web. Production freeciv-web should use S2_5 server (and even that's not yet in savegame format freeze, but should be a lot safer than trunk anyway)

Marko Lindqvist <cazfi>
Project Administrator
Wed 19 Jun 2013 09:46:54 PM UTC, comment #2:

The user Eridanus clicks on "Load savegame" in Freeciv-web, then the savegame is transferred from the users local-storage in the browser to the Freeciv-web server, compared against the hash of the savegame in the database for security and integrity check, and then loaded by the Freeciv server. The savegame is lost now, since savegames on the server are regularly deleted from disk.

This savegame crash happens 4 times. There are also other assertions in the log which are more frequent.

Andreas Rosdal <andreasr>
Project Member
Wed 19 Jun 2013 09:29:51 PM UTC, comment #1:

Where does that "Eridanus" savegame that fails to load comes from?

Marko Lindqvist <cazfi>
Project Administrator
Wed 19 Jun 2013 09:04:21 PM UTC, original submission:

I have grepped the Freeciv server logs on the freeciv-web production server for failed assertions, since these logs can help us reduce server crashes. Please see the attachment.

Freeciv trunk revision 22904. Freeciv-web as latest github version.

Andreas Rosdal <andreasr>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by mir3x (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by andreasr (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 26 Aug 2013 04:57:47 PM UTCjtnRelease=>trunk
      SummaryServer crashes in freeciv server=>[metaticket] freeciv-server crashes seen on play.freeciv.org
    Tue 25 Jun 2013 09:18:40 PM UTCcazfiAssigned tocazfi=>None
    Thu 20 Jun 2013 06:53:32 PM UTCandreasrSummaryMany server crashes in freeciv server=>Server crashes in freeciv server
    Wed 19 Jun 2013 09:04:21 PM UTCandreasrAttached File-=>Added freeciv-server-crashes.txt, #18122
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup