bugBattle for Wesnoth - Bugs: bug #20924, MICRO_AI_GOTO parameter...

 
 
Show feedback again

bug #20924: MICRO_AI_GOTO parameter release_all_units_at_goal corrupts saves

Submitted by:  Nate Wright <natewr>
Submitted on:  Fri 21 Jun 2013 02:15:19 PM UTC  
 
Category: BugSeverity: 4 - Important
Priority: 5 - NormalItem Group: Artificial Intelligence
Status: FixedPrivacy: Public
Assigned to: Matthias Schoeck <mattsc>Open/Closed: Closed
Release: 1.11.4Operating System: Win7

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 24 Jun 2013 05:06:18 PM UTC, comment #4:

I can confirm the fix in my own case. I confirmed the fix just by copying the changed lua file over my existing 1.11.4 installation. I can reconfirm with 1.11.5 when it's released if that's preferred, but this can probably be closed.

Nate Wright <natewr>
Sat 22 Jun 2013 03:20:13 PM UTC, comment #3:

This is fixed in commit b83e68711cb72f318d4e78699c25dd77fc709f39
http://git.io/uqJZcg

For future reference, the reason was that some of the persistent data the Micro AI stores from turn to turn did not conform with WML table format. Some of it contained hyphens (which was a trivial fix), but some potentially user-defined information (CA and unit IDs) also needs to be stored, and since these can contain characters that cannot be used for WML tags and keys, the way the information is stored needed to be restructured.

Thanks again for reporting. I'll mark the bug as fixed but leave it open for now, in case you encounter more problems.

Matthias Schoeck <mattsc>
Project MemberIn charge of this item.
Fri 21 Jun 2013 03:47:28 PM UTC, comment #2:

I have confirmed with my own test scenario that the Goto MAI corrupts saves somehow, although in my case it seems to happen more generally than only for the release_all_units_at_goal parameter.

I will look into this, thanks for reporting.

Matthias Schoeck <mattsc>
Project MemberIn charge of this item.
Fri 21 Jun 2013 02:16:45 PM UTC, comment #1:

Sorry, reproduction steps should mention the scenario to load is called "Micro AI save corruption".

Nate Wright <natewr>
Fri 21 Jun 2013 02:15:19 PM UTC, original submission:

When using MICRO_AI_GOTO, I have set the release_all_units_at_goal parameter to yes. Once the unit reaches its goal, all subsequent saves are corrupt.

I've created a small demo example for reproducing corrupt saves. To test, install the addon in the attached zip file. Load a localhost multiplayer game. The AI side should move its unit to the castle tile on the right. All saves before this are valid. All saves after are false.

To confirm it is the release_all_units_at_goal parameter, comment out line 79 of /add-ons/corrupt-save-test/scenarios/corrupt-save-test.cfg.

Nate Wright <natewr>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18140:  corrupt_save_test.zip added by natewr (2kB - application/x-zip-compressed - Small add-on to reproduce corrupted saves)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by mattsc (Posted a comment)
  • -unavailable- added by natewr (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 27 Jun 2013 10:05:29 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sat 22 Jun 2013 03:20:13 PM UTCmattscStatusIn Progress=>Fixed
    Fri 21 Jun 2013 03:47:28 PM UTCmattscStatusNone=>In Progress
      Assigned toNone=>mattsc
    Fri 21 Jun 2013 02:15:19 PM UTCnatewrAttached File-=>Added corrupt_save_test.zip, #18140
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup