bugBattle for Wesnoth - Bugs: bug #20933, [base_unit] doesn't work for...

 
 
Show feedback again

bug #20933: [base_unit] doesn't work for females

Submitted by:  Nate Wright <natewr>
Submitted on:  Fri 28 Jun 2013 09:32:25 AM UTC  
 
Category: BugSeverity: 4 - Important
Priority: 5 - NormalItem Group: WML
Status: FixedPrivacy: Public
Assigned to: J Tyne <jamit>Open/Closed: Closed
Release: 1.11.5Operating System: Win7

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 01 Jul 2013 03:06:45 AM UTC, comment #3:

Fixed in 41f8816872584603bb9ba2c955947c078997f6a7.

Note that the name of the female "Mage" type is set within its [female] tag. That means the female variant of a derived type will keep that name (_"female^Mage") unless it is specifically set within the derived unit (which is a good idea anyway, to prepare for translations).

J Tyne <jamit>
Project MemberIn charge of this item.
Fri 28 Jun 2013 11:09:54 PM UTC, comment #2:

i took a look at the code and i think the problem is that [female] of the base_unit is pocecced before the [base_unit] of the other unit, so the other units inherits the already completed [female] of the base_unit

i think this was changed in this commit: 81159e7c42e270077f0203dad820dc024a76a9ae

Anonymous
Fri 28 Jun 2013 06:52:30 PM UTC, comment #1:

i did some testing and i found out thats this bug only appears if the base_unit unitcfg is processed before the other unit, so the behaviour depends on wich unitsconfigs are processed first. (when the base unit is a core units it is aleway processed first.)

Anonymous
Fri 28 Jun 2013 09:32:25 AM UTC, original submission:

The following WML will not produce Apprentice Mages for females. When an Apprentice Mage is recruited, the id and name values are used for the [base_unit].

[unit_type]
[base_unit]
id=Mage
[/base_unit]
id=Apprentice Mage
name = _ "Apprentice Mage"
[female]
inherit=yes
[/female]
[/unit_type]

I've attached a simple addon to reproduce this. Install the addon and then load a multiplayer game. Choose the map "Base Unit Test". You can recruit Apprentice Mages. The males will appear correctly. The females will not.

Nate Wright <natewr>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18183:  base_unit_test.zip added by natewr (2kB - application/x-zip-compressed)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jamit (Updated the item)
  • -unavailable- added by natewr (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 17 Aug 2013 09:58:42 PM UTCjamitOpen/ClosedOpen=>Closed
    Mon 01 Jul 2013 03:06:45 AM UTCjamitStatusNone=>Fixed
    Sat 29 Jun 2013 08:00:46 PM UTCjamitAssigned toNone=>jamit
    Fri 28 Jun 2013 09:32:25 AM UTCnatewrAttached File-=>Added base_unit_test.zip, #18183
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup