bugFreeciv - Bugs: bug #20956, Bombarding an empty city allows...

 
 
Show feedback again

bug #20956: Bombarding an empty city allows veterancy gains.

Submitted by:  None
Submitted on:  Wed 10 Jul 2013 07:48:21 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Originator Email: -unavailable-
Open/Closed: ClosedRelease: 2.3.4
Operating System: AnyPlanned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 16 Feb 2015 08:46:18 AM UTC, SVN revision 28182:

A bombarder unit attacking an empty city now attempts to occupy it,
rather than possibly gaining veterancy.

Reported anonymously.

See gna bug #20956.

(Browse SVN revision 28182)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 16 Feb 2015 08:44:40 AM UTC, SVN revision 28177:

A bombarder unit attacking an empty city now attempts to occupy it,
rather than possibly gaining veterancy.

Reported anonymously.

See gna bug #20956.

(Browse SVN revision 28177)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 16 Feb 2015 08:32:28 AM UTC, SVN revision 28171:

A bombarder unit attacking an empty city now attempts to occupy it,
rather than possibly gaining veterancy.

Reported anonymously.

See gna bug #20956.

(Browse SVN revision 28171)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 16 Feb 2015 08:21:59 AM UTC, SVN revision 28164:

A bombarder unit attacking an empty city now attempts to occupy it,
rather than possibly gaining veterancy.

Reported anonymously.

See gna bug #20956.

(Browse SVN revision 28164)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 14 Feb 2015 01:42:29 PM UTC, comment #7:

> remove the maybe_make_veteran() from the end of unit_bombard()

No, do the thing cazfi said in comment #1, which doesn't disturb veterancy on S2_4 when there are defenders.
(The maybe_make_veteran() will be removed in patch #5835.)

(file #23812, file #23813)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 14 Feb 2015 12:21:58 PM UTC, comment #6:

> A simple solution would be to simply get rid of all veteran
> gains during bombardment.

Moved this proposal to new patch #5835.

Keeping this bug for original complaint. I think this is uncontroversial, and easy to fix on all branches including S2_4: remove the maybe_make_veteran() from the end of unit_bombard(). (On S2_4, attacker will still get veteran chance if it damages units.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 14 Feb 2015 11:41:14 AM UTC, comment #5:

Also, I think defenders can get veteran levels quite quickly if they are repeatedly bombarded. If you can't crack a city immediately and it has Barracks, it will have much stronger units with full HP for free quite quickly.

A simple solution would be to simply get rid of all veteran gains during bombardment. Veterancy can be seen as a bonus for survival, and there is no risk of death during bombardment.

Any objections to that for 2.5?

We can add it back as a possibility in later versions when we have tools for more control over veteran chance (like patch #5833 proposes).

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 13 Feb 2015 09:20:07 AM UTC, comment #4:

Also, it looks like the bombarder gets a chance at veterancy for every unit on the target tile, so civ2civ3 Bombers tend to become Elite very quickly.

I'm thinking of changing this for 2.5.0 (so there's only one chance at veterancy per attack). Objections?

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 18 Nov 2013 07:58:21 AM UTC, comment #3:

Is this "bombard" in the technical sense. Yes
Longturn is using the civ2civ3 ruleset which has the bombard flag for bombers and helicopters.
The helicopter can occupy the city. The bomber can't.
The error comes with bombers.

It is easy to replicate.
Start a game with the civ2civ3 ruleset.
enter edit mode
give yourself 10 bombers outside an empty enemy city.
attack the city
some of your bombers will now be veteran

Anonymous
Mon 26 Aug 2013 04:54:48 PM UTC, comment #2:

Is this "bombard" in the technical sense (unit has "Bombarder" flag, and it's active, so unit can't kill defender but doesn't receive return fire)?
(No units in the default ruleset have the "Bombarder" flag.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 12 Jul 2013 10:36:58 PM UTC, comment #1:

Depending on whether unit has CanOccupy -flag it should either occupy the city or get the error message that it cannot.

Marko Lindqvist <cazfi>
Project Administrator
Wed 10 Jul 2013 07:48:21 AM UTC, original submission:

If you bombard an empty city the combat animation is shown and the bombarding unit may gain veterancy.

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23812:  trunk-S2_6-S2_5-bombard-empty-city.patch added by jtn (1kB - text/x-patch - trunk/S2_6/S2_5/S2_4 r28127)
file #23813:  S2_4-bombard-empty-city.patch added by jtn (1kB - text/x-patch - trunk/S2_6/S2_5/S2_4 r28127)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 16 Feb 2015 08:48:07 AM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 14 Feb 2015 01:42:29 PM UTCjtnAttached File-=>Added trunk-S2_6-S2_5-bombard-empty-city.patch, #23812
      Attached File-=>Added S2_4-bombard-empty-city.patch, #23813
      StatusNone=>Ready For Test
      Assigned toNone=>jtn
      Operating SystemNone=>Any
    Sat 14 Feb 2015 12:21:58 PM UTCjtnPlanned Release2.5.0, 2.6.0, 3.0.0=>2.4.5, 2.5.0, 2.6.0, 3.0.0
    Sat 14 Feb 2015 11:43:45 AM UTCjtnPlanned Release=>2.5.0, 2.6.0, 3.0.0
    Fri 12 Jul 2013 10:36:58 PM UTCcazfiCategoryNone=>general
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup