bugFreeciv - Bugs: bug #20960, Server crash - while processing...

 
 
Show feedback again

bug #20960: Server crash - while processing spy sabotage info from client

Submitted by:  mir3x <mir3x>
Submitted on:  Wed 10 Jul 2013 07:28:55 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: trunk post-2.5Operating System: Any
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 08 Feb 2014 08:17:16 PM UTC, comment #1:

This looks like it might be the same bug as was fixed in bug #21558. And the stated client modification is consistent with what we found there (although I don't know why else you'd modify the client like that).
Is it possible it was the original reporter of this bug was playing Longturn when it crashed?

Jacob Nevins <jtn>
Project Administrator
Wed 10 Jul 2013 07:28:55 PM UTC, original submission:

Server crash when sabotaging improvement with
modified client

(in gtk2 client change in diplomat_dialog.c
in line 356:
from
diplomat_target_id, sabotage_improvement + 1);

to
diplomat_target_id, sabotage_improvement);

Load attached save_game, choose acive spy,
sabotage -At spy disrection- nearest city

client will send B_LAST as improvement number
and server will crash.

Last log from server:
3: got packet type=(PACKET_UNIT_DIPLOMAT_ACTION)84 len=12 from xontastic
3: packet_unit_diplomat_action_100: got info about ()
3: no old info
3: got field 'diplomat_id'
3: got field 'target_id'
3: got field 'value'
3: got field 'action_type'
3: packet_processing_started_100: sending info about ()
3: sending packet type=PACKET_PROCESSING_STARTED(0) len=4 to xontastic

mir3x <mir3x>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18240:  serv_crash.sav.bz2 added by mir3x (53kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by mir3x (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 26 Aug 2013 04:53:06 PM UTCjtnPlanned Release=>2.6.0
    Mon 26 Aug 2013 04:52:48 PM UTCjtnRelease=>trunk post-2.5
    Wed 10 Jul 2013 07:28:56 PM UTCmir3xAttached File-=>Added serv_crash.sav.bz2, #18240
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup