bugFreeciv - Bugs: bug #20994, Badly constructed translatable...

Show feedback again

bug #20994: Badly constructed translatable strings in qt-client

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue Jul 30 07:49:32 2013  
Category: client-qtSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: mir3x <mir3x>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.5.0,2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat Nov 16 15:59:30 2013, SVN revision 23751:

Fixed some badly constructed strings

See gna bug #20994

(Browse SVN revision 23751)

mir3x <mir3x>
Project MemberIn charge of this item.
Sat Nov 16 15:59:17 2013, SVN revision 23750:

Fixed some badly constructed strings

See gna bug #20994

(Browse SVN revision 23750)

mir3x <mir3x>
Project MemberIn charge of this item.
Fri Oct 25 19:10:06 2013, comment #1:

Fixed, but those strings were translated correctly before,
now they are untranslated ( gtk uses sign '_' to make shortcut to menu, so all menu translations are useless, so I wasnt using standard %s to mark strings , but native qt - %n, where n is int)

(file #19244)

mir3x <mir3x>
Project MemberIn charge of this item.
Tue Jul 30 07:49:32 2013, original submission:

Noticed in menu.cpp:

QString(_("Transform to")) + " " + QString(get_tile_change_menu_text

That's not right for translatability. Translators should be able to set the word order instead of it being hardcoded to "Transform to" in the beginning and target terrain in the end. That is: translatable string should be format like "Transform to %s".

I haven't checked if there's more cases like this.

Marko Lindqvist <cazfi>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #19244:  qt-trans-fix.patch added by mir3x (3kB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by mir3x (Updated the item)
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Nov 16 16:00:42 2013mir3xStatusReady For Test=>Fixed
      Assigned toNone=>mir3x
    Fri Oct 25 19:10:06 2013mir3xAttached File-=>Added qt-trans-fix.patch, #19244
      StatusNone=>Ready For Test
    Mon Aug 26 16:48:03 2013jtnPlanned Release=>2.5.0,2.6.0
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup