bugFreeciv - Bugs: bug #21022, Problems in determining move_type...

 
 
Show feedback again

bug #21022: Problems in determining move_type for units native to roads

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 12 Aug 2013 03:50:06 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.1, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 30 Sep 2013 05:01:58 PM UTC, SVN revision 23515:

When automatically determining unit's move type, consider only nativity provided
by bases.

See bug #21022

(Browse SVN revision 23515)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 30 Sep 2013 05:01:09 PM UTC, SVN revision 23514:

When automatically determining unit's move type based on native roads and bases, respect
the terrain requirements of them instead of assuming that they are always
on land terrains only. Also consider only those roads and bases that have "NativeTile" flag.

See bug #21022

(Browse SVN revision 23514)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 30 Sep 2013 04:58:02 PM UTC, SVN revision 23513:

When automatically determining unit's move type based on native extras, respect
the terrain requirements of the extras instead of assuming that extras are always
on land terrains only.

See bug #21022

(Browse SVN revision 23513)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 27 Sep 2013 04:45:36 AM UTC, comment #7:

- Special handling for rivers added

Separate patch for experimental ruleset Maglevs needed.

(file #19094, file #19095)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 23 Sep 2013 11:08:38 PM UTC, comment #6:

Rivers generated by map generator need special handling, as they have no configured requirement "TerrainClass Land" while that's hardcoded to map generator.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 20 Sep 2013 12:32:48 PM UTC, comment #5:

- Iterate requirement vector as one, and not as requirement list

(file #19050, file #19051, file #19052)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 17 Sep 2013 06:54:45 PM UTC, comment #4:

- S2_4 version. This just adds handling of move_type derived from native bases

(file #19029)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 17 Sep 2013 06:44:41 PM UTC, comment #3:

- S2_5 version
- New TRUNK version with error message fixed not to mention "sea moving" where restriction can be either land of sea movement.

(file #19027, file #19028)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 17 Sep 2013 06:24:58 PM UTC, comment #2:

TRUNK patch. That's easier than stable brances, as all the extras can be handled at once.

This is not perfect, as we consider only requirements of types TerrainClass and Terrain for extras when determining where the extra can appear, and thus provide nativity for units inside. Something like TerrrainFlag requirement when all the terrains having the flag belong to the same class, or even requirement of another extra that itself is restricted to one terrain class only could result in limitation that we don't notice. I think we ultimately have to live with some limitations of the move_type detection (even though situation could be improved somewhat). This can only mean that extra is assumed to give UMT_BOTH movement instead of stricter UMT_LAND or UMT_SEA. This in turn means that automatic move_type detection may give UMT_BOTH to unit that could have stricter move_type, or sanity checking of the explicitly given strict move_type to fail as unit seems to have nativity to UMT_BOTH extra.

(file #19026)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 12 Aug 2013 04:29:26 PM UTC, comment #1:

Also, any native road is considered to make also tile native while on should check road's "NativeTile" -flag.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 12 Aug 2013 03:50:06 PM UTC, original submission:

After gen-roads (that is: S2_5 being affected) code that sets unit move_type based on native terrains and roadshas several problems. It assumes that roads are always on land. It both determines that unit native to any road must be able to land travel via that road (not true if road itself is not native to any land terrain) and forbids sea moving units from being native to any road (roads native to sea terrains only should be ok).

Another problem that affects even S2_4 is that nativity provided by bases is not considered at all like that provided by roads.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19094:  DerivedMovetype-4.patch added by cazfi (5kB - text/x-diff)
file #19050:  DerivedMovetype-3.patch added by cazfi (4kB - text/x-diff)
file #19028:  DerivedMovetype-2.patch added by cazfi (4kB - text/x-diff)
file #19026:  DerivedMovetype.patch added by cazfi (4kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 16 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 30 Sep 2013 05:02:10 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 27 Sep 2013 04:45:36 AM UTCcazfiAttached File-=>Added DerivedMovetype-4.patch, #19094
      Attached File-=>Added DerivedMovetype-S2_5-4.patch, #19095
      StatusIn Progress=>Ready For Test
    Mon 23 Sep 2013 11:08:38 PM UTCcazfiStatusReady For Test=>In Progress
    Fri 20 Sep 2013 12:32:48 PM UTCcazfiAttached File-=>Added DerivedMovetype-3.patch, #19050
      Attached File-=>Added DerivedMovetype-S2_5-3.patch, #19051
      Attached File-=>Added DerivedMovetype-S2_4-3.patch, #19052
    Tue 17 Sep 2013 06:54:45 PM UTCcazfiAttached File-=>Added DerivedMovetype-S2_4.patch, #19029
      StatusNone=>Ready For Test
    Tue 17 Sep 2013 06:44:41 PM UTCcazfiAttached File-=>Added DerivedMovetype-S2_5.patch, #19027
      Attached File-=>Added DerivedMovetype-2.patch, #19028
    Tue 17 Sep 2013 06:24:57 PM UTCcazfiAttached File-=>Added DerivedMovetype.patch, #19026
      Planned Release=>2.4.1, 2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup