bugFreeciv - Bugs: bug #21045, mapimg help misleading when...

 
 
Show feedback again

bug #21045: mapimg help misleading when there's no MagickWand support

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 21 Aug 2013 09:42:39 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 21 Aug 2013 09:52:49 PM UTC, comment #1:

We introduced run-time-variable command help just so mapimg_help() could carefully constructs a list of compiled-in toolkits (IIRC), but I suppose the examples aren't conditionalised:

I think I thought at the time that making all the examples mention "format=ppm" in the non-MagickWand case would make a user who'd only seen a non-IM build wonder "so what's the point of this format parameter for anyway if it can only ever take one value" -- I left them in to demonstrate that variety was possible.

But I suppose we could construct an alternative set of examples if there's only on tool/format which omit the 'format' argument.

(Also, i18n. But since the examples are non-translatable, we can get away with making the whole block a %s whose values aren't marked for i18n.)

Jacob Nevins <jtn>
Project Administrator
Wed 21 Aug 2013 09:42:39 PM UTC, original submission:

/help mapimg examples list formats that are available only with MagickWand. Giving mapimg definitions like those listed, while MagickWand support is not compiled in (such as I'm now forced to do with OpenEmbedded builds), results in error.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup