bugFreeciv - Bugs: bug #21060, Cosmetic issues in Windows...

 
 
Show feedback again

bug #21060: Cosmetic issues in Windows installer language selection

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 24 Aug 2013 01:53:59 PM UTC  
 
Category: generalSeverity: 2 - Minor
Priority: 5 - NormalStatus: Ready For Test
Assigned to: NoneOpen/Closed: Open
Release: 2.4.0-RC1Operating System: Microsoft Windows
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 16 Nov 2013 01:00:11 PM UTC, SVN revision 23747:

Change "American English" to "US English" in installer.

Part of gna bug #21060.

(Browse SVN revision 23747)

Jacob Nevins <jtn>
Project Administrator
Sat 16 Nov 2013 12:56:10 PM UTC, SVN revision 23746:

Change "American English" to "US English" in installer.

Part of gna bug #21060.

(Browse SVN revision 23746)

Jacob Nevins <jtn>
Project Administrator
Sat 16 Nov 2013 12:55:14 PM UTC, SVN revision 23745:

Change "American English" to "US English" in installer.

Part of gna bug #21060.

(Browse SVN revision 23745)

Jacob Nevins <jtn>
Project Administrator
Sat 16 Nov 2013 12:30:02 PM UTC, comment #10:

> for completeness sake one should note that en_US is separately
> added to the beginning of the list, while rest are alphabetical
> sorted. By luck "American English" would fit the alphabetical
> order (at least close, I haven't checked)

Mm, true. I can live with that, though; en_US is clearly special in the installer, since you can't not install it.

> We may also want to reconsider adding native names of the
> languages.

I've thought so too. However, we'd definitely want to have a Unicode-clean path all the way to the installer, on all supported versions of Windows (and even then I'd be worried that the user's system might fail to display some characters due to lack of font support).
A choice of "English, □□□□□, □□, or □□□□□□□□" is probably more annoying to people who want other languages than the current situation :)

Jacob Nevins <jtn>
Project Administrator
Sun 10 Nov 2013 10:37:35 AM UTC, comment #9:

Not that I'm against the change, but for completeness sake one should note that en_US is separately added to the beginning of the list, while rest are alphabetical sorted. By luck "American English" would fit the alphabetical order (at least close, I haven't checked)

We may also want to reconsider adding native names of the languages. That seems to be quite common practice - One has to understand header like "Choose your language" in English, but then actual language name in the list is "Suomi" instead of "Finnish".

Marko Lindqvist <cazfi>
Project Administrator
Sun 10 Nov 2013 01:09:45 AM UTC, comment #8:

Thanks for testing this and doing this. (I agree the language code should remain visible.)
Cosmetic: I propose tweaking "American English" to "US English".

(file #19350)

Jacob Nevins <jtn>
Project Administrator
Sun 03 Nov 2013 01:08:10 AM UTC, SVN revision 23681:

Show language name in Windows installer default language selection, not language
code only.

Requested by Jacob Nevins

See bug #21060

(Browse SVN revision 23681)

Marko Lindqvist <cazfi>
Project Administrator
Sun 03 Nov 2013 01:08:05 AM UTC, SVN revision 23680:

Show language name in Windows installer default language selection, not language
code only.

Requested by Jacob Nevins

See bug #21060

(Browse SVN revision 23680)

Marko Lindqvist <cazfi>
Project Administrator
Sun 03 Nov 2013 01:07:59 AM UTC, SVN revision 23679:

Show language name in Windows installer default language selection, not language
code only.

Requested by Jacob Nevins

See bug #21060

(Browse SVN revision 23679)

Marko Lindqvist <cazfi>
Project Administrator
Wed 30 Oct 2013 07:21:25 PM UTC, comment #4:

Patch worked.

New, hopefully final, version:
- Also sdl-client package handled
- Have also language code visible as in "Finnish (fi)"

(file #19295)

Marko Lindqvist <cazfi>
Project Administrator
Tue 29 Oct 2013 01:20:12 AM UTC, comment #3:

For the UTF-8 problem this might be useful link:
http://nsis.sourceforge.net/Utf8Converter

Marko Lindqvist <cazfi>
Project Administrator
Tue 29 Oct 2013 01:17:32 AM UTC, comment #2:

Here's an idea (as a patch) I'm going to test next time I have opportunity to use Windows environment.

List language names instead of codes in the dropdown.
Have code to convert from language name to language code generated to nsi-file, for each language:

${If} $LangName == "Finnish"
StrCpy $DefaultLanguageCode "fi"
${EndIf}

Patch is for gtk2-client version only. Once I've got that working, it's trivial to make similar changes to sdl-client version.

(file #19275)

Marko Lindqvist <cazfi>
Project Administrator
Sat 24 Aug 2013 06:59:45 PM UTC, comment #1:

> This doesn't look completely trivial, as it looks like the
> display name and output name are currently tied. I'm sure it's
> possible to change the NSIS script to separate them, but I
> haven't looked into it as I wouldn't be set up to test any
> changes.


When I looked it, it seemed that one cannot have distinct "displayed text" and "selected value" there, but I'm certainly not expert of nsis control language. So it would be something like "en_GB - British English" both dislayed in selection dialog and got as value when use selects it - somewhere it would need to be parsed to "en_GB" only.

Marko Lindqvist <cazfi>
Project Administrator
Sat 24 Aug 2013 01:53:59 PM UTC, original submission:

1.
The description of the "nb" language code (Norwegian Bokmål) is mangled on display, at least on my (Windows 7 British English) system. See screenshot. It looks to me like UTF-8 interpreted as ISO 8859-1 or Win1252.

bootstrap/langnames.txt (from which this string comes) is encoded in UTF-8. I'm guessing that encoding will pass straight through create-freeciv-gtk2-nsi.sh to the NSIS script, and what happens then will depend on NSIS' character set handling.

Is there some way to tell NSIS that the script it's been given is UTF-8 encoded, and if so will everything from then on Just Work?

Failing that, we could take the pragmatic step of changing the encoding of langnames.txt in svn to ISO 8859-1.

2.
While the "Choose Components" screen has friendly language names, the "Choose Default Language" step just has language codes. It would be nice if it displayed language names. (This is a left-over from patch #3463.)

This doesn't look completely trivial, as it looks like the display name and output name are currently tied. I'm sure it's possible to change the NSIS script to separate them, but I haven't looked into it as I wouldn't be set up to test any changes.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19350:  trunk-S2_5-S2_4-installer-us-english.patch added by jtn (2kB - text/x-diff - trunk/S2_5/S2_4 r23711)
file #19295:  NsisRealLangNames-2.patch added by cazfi (4kB - text/x-diff)
file #19275:  NsisRealLangNames.patch added by cazfi (2kB - text/x-diff)
file #18750:  lang3.png added by jtn (38kB - image/png - 2.4.0-RC1 Windows installer, nb (Norwegian Bokmål) name mangled)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 06 Dec 2014 11:53:36 AM UTCjtnPlanned Release2.4.1, 2.5.0, 2.6.0=>
    Sun 10 Nov 2013 01:09:45 AM UTCjtnAttached File-=>Added trunk-S2_5-S2_4-installer-us-english.patch, #19350
    Wed 30 Oct 2013 07:21:25 PM UTCcazfiAttached File-=>Added NsisRealLangNames-2.patch, #19295
      StatusNone=>Ready For Test
      Assigned tocproc=>None
      Planned Release=>2.4.1, 2.5.0, 2.6.0
    Tue 29 Oct 2013 01:17:32 AM UTCcazfiAttached File-=>Added NsisRealLangNames.patch, #19275
    Sat 24 Aug 2013 02:03:48 PM UTCjtnOperating SystemNone=>Microsoft Windows
    Sat 24 Aug 2013 01:53:59 PM UTCjtnAttached File-=>Added lang3.png, #18750
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup