bugFreeciv - Bugs: bug #21065, MapSizesare still doing buggy...

 
 
Show feedback again

bug #21065: MapSizesare still doing buggy things in RC1

Submitted by:  None
Submitted on:  Mon 26 Aug 2013 01:30:08 AM UTC  
 
Category: client-gtk-2.0Severity: 3 - Normal
Priority: 5 - NormalStatus: Need Info
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: OpenRelease: 2.4.0-RC1
Operating System: Microsoft WindowsPlanned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 27 Aug 2013 05:19:03 AM UTC, comment #2:

"The only oddity is the error message reporting where it gives you two messages including the previous xsize/ysize respectively"

Exactly!

The use of the client GUI implies to the human an assumption that many items can be edited and then executed to the server and/or saved. i gave up on the GUI and just started editing the settings file the GUI saves to for reliability sake.

Anonymous
Mon 26 Aug 2013 10:03:26 AM UTC, comment #1:

Can you explain exactly where you think the bug is?

In all the cases below I think your (xsize, ysize) combinations have been correctly either accepted or connected.

The only oddity is the error message reporting where it gives you two messages including the previous xsize/ysize respectively:

I infer from the "Saved settings" messages that you're changing these settings in the client. Unfortunately, the UI where you edit both and submit them together is not reflected in the protocol; the server receives the changes to each of xsize and ysize in separate packets and validates them individually, as it has no way of knowing they're part of a set.

As a result, I think that it would be possible to get an erroneous rejection when trying to change from a very wide*tall to a tall*wide map (not that you've triggered this).

We have a similar issue loading savegames and server scripts (where it is a more serious problem); I hadn't considered that the client UI suffers from the same thing. If we are to fix all of these, I think we need to make it possible to present (xsize,ysize) atomically, either via some notion of transactions on settings as a whole (which will deal with complex interdependencies), or by inventing complex compound setting types.

Jacob Nevins <jtn>
Project Administrator
Mon 26 Aug 2013 01:30:08 AM UTC, original submission:

It looks like somefixes were added to 2.4.0 RC1, but it still appears quite borked:

[20:17:39] Play: 'set mapsize "XYSIZE"'
[20:17:39] Console: 'mapsize' has been set to "Width and height" (XYSIZE).
[20:17:39] Play: 'set xsize 32768'
[20:17:39] /set: The map size (32768 * 252 = 8257536) must be lower than 2048000 tiles.
[20:17:39] Play: 'set ysize 32768'
[20:17:39] /set: The map size (126 * 32768 = 4128768) must be lower than 2048000 tiles.
[20:20:07] Saved settings to file C:/Documents and Settings/Play/Application Data/.freeciv-client-rc-2.4
[20:20:10] Play: 'set xsize 666'
[20:20:10] Console: 'xsize' has been set to 666.
[20:20:10] Play: 'set ysize 444'
[20:20:10] Console: 'ysize' has been set to 444.
[20:20:32] Saved settings to file C:/Documents and Settings/Play/Application Data/.freeciv-client-rc-2.4
[20:20:34] Play: 'set xsize 999'
[20:20:34] Console: 'xsize' has been set to 999.
[20:20:34] Play: 'set ysize 666'
[20:20:34] Console: 'ysize' has been set to 666.
[20:20:59] Saved settings to file C:/Documents and Settings/Play/Application Data/.freeciv-client-rc-2.4
[20:21:01] Play: 'set xsize 3333'
[20:21:01] /set: The map size (3333 * 666 = 2219778) must be lower than 2048000 tiles.
[20:21:01] Play: 'set ysize 2222'
[20:21:01] /set: The map size (999 * 2222 = 2219778) must be lower than 2048000 tiles.
[20:21:58] Saved settings to file C:/Documents and Settings/Play/Application Data/.freeciv-client-rc-2.4
[20:22:01] Saved settings to file C:/Documents and Settings/Play/Application Data/.freeciv-client-rc-2.4
[20:22:04] Play: 'set xsize 3333'
[20:22:04] /set: The map size (3333 * 666 = 2219778) must be lower than 2048000 tiles.
[20:22:04] Play: 'set ysize 2222'
[20:22:04] /set: The map size (999 * 2222 = 2219778) must be lower than 2048000 tiles.
[20:22:48] Saved settings to file C:/Documents and Settings/Play/Application Data/.freeciv-client-rc-2.4
[20:22:52] Play: 'set xsize 16'
[20:22:52] Console: 'xsize' has been set to 16.
[20:22:52] Play: 'set ysize 16'
[20:22:52] Console: 'ysize' has been set to 16.
[20:23:24] Saved settings to file C:/Documents and Settings/Play/Application Data/.freeciv-client-rc-2.4
[20:23:26] Play: 'set xsize 3333'
[20:23:26] Console: 'xsize' has been set to 3333.
[20:23:26] Play: 'set ysize 2222'
[20:23:26] /set: The map size (3333 * 2222 = 7405926) must be lower than 2048000 tiles.
[20:24:01] Saved settings to file C:/Documents and Settings/Play/Application Data/.freeciv-client-rc-2.4

etc.

It might be the GUI?

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 26 Aug 2013 12:29:32 PM UTCjtnStatusNone=>Need Info
    Mon 26 Aug 2013 10:03:26 AM UTCjtnRelease2.4.0 RC1=>2.4.0-RC1
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup