bugFreeciv - Bugs: bug #21066, Unwanted fallback from FRACTAL to...

 
 
Show feedback again

bug #21066: Unwanted fallback from FRACTAL to RANDOM map generator

Submitted by:  None
Submitted on:  Mon 26 Aug 2013 04:06:36 AM UTC  
 
Category: client-gtk-2.0Severity: 3 - Normal
Priority: 5 - NormalStatus: Need Info
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: OpenRelease: 2.4.0-RC1
Operating System: Microsoft WindowsPlanned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 27 Aug 2013 05:11:09 AM UTC, comment #5:

I ran a search for FRACTAL on this GNA and got these prior bug reports which help explain things (btw, changing the Bug Report titles makes it hard for me to locate my original anonymous BRs, but that's fine to do if it helps):

https://gna.org/bugs/?func=detailitem&item_id=20831
https://gna.org/bugs/?func=detailitem&item_id=20649
https://gna.org/bugs/?func=detailitem&item_id=20539
https://gna.org/bugs/?func=detailitem&item_id=20171
https://gna.org/bugs/?func=detailitem&item_id=19886
https://gna.org/bugs/?func=detailitem&item_id=18538 (interesting)
https://gna.org/bugs/?func=detailitem&item_id=18533 (will arise during attempts to work-around?)
https://gna.org/bugs/?func=detailitem&item_id=17352
https://gna.org/bugs/?func=detailitem&item_id=16651 (this one)

Anonymous
Mon 26 Aug 2013 02:40:21 PM UTC, comment #4:

> Don't believe what it reads in log_verbose() calls. They all
> start with "ISLAND:" but actually are in all of mapgenerator2(),
> mapgenerator3(), mapgenerator4().

I only see invocations of those functions from inside a "if (MAPGEN_ISLAND == map.server.generator)" clause, so I concluded that they were all in fact about the island generator. (The function names don't seem to correspond to the old numeric 'generator' option values; don't know where the numbers came from.)

Jacob Nevins <jtn>
Project Administrator
Mon 26 Aug 2013 01:46:23 PM UTC, comment #3:

> the only actual intentional fallbacks I find are from the
> "Island-based" (ISLAND) generator to something else


Don't believe what it reads in log_verbose() calls. They all start with "ISLAND:" but actually are in all of mapgenerator2(), mapgenerator3(), mapgenerator4().

Marko Lindqvist <cazfi>
Project Administrator
Mon 26 Aug 2013 12:21:37 PM UTC, comment #2:

The server help for the 'generator' setting does hint that this is a possibility:

However, looking at the code, the only actual intentional fallbacks I find are from the "Island-based" (ISLAND) generator to something else, generally in cases where the requested value of 'landmass' is too high.

I haven't spotted any cases where if you specify the "Pseudo-fractal height" (FRACTAL) generator, it will fall back to the "Fully random height" (RANDOM) generator.

Can you provide the complete set of settings you are using to provoke this? (Or a savegame of the resulting map will probably do just as well.)

In general, if you start the server with "-d 3", it will tell you when it is forced to fall back to something other than what you asked for.
(However, I gather you're spawning the server from the client; there isn't an option for this in the client. Starting a standalone server is likely to perturb things too much.)

The interaction of generator/startpos and the fallback strategy is a bit of a mess. I tried to improve it by adding comments and log messages a while back, but coming back to it it's still hard to follow, so it could use more improvement.

Jacob Nevins <jtn>
Project Administrator
Mon 26 Aug 2013 04:53:59 AM UTC, comment #1:

Ok, this has to do with the startpos=VARIABLE setting, apparently FRACTAL cannot deal with it as one would assume, and when it cannot it actually changes the map creator to a RANDOM map. The work-around appears to be to generate the map with one player, delete the player start position, and re-load the map as a SCENARIO map. Why FreeCiv cannot do this to begin with is beyond my reasoning, i guess that process needs a human.

Anonymous
Mon 26 Aug 2013 04:06:36 AM UTC, original submission:

Where has the FRACTAL map generator in FreeCiv gone? Why has it been either taken out of the code or been deactivated? When i choose it, what i really get is the RANDOM generator, which is pretty horrible, everything is mixed together and helter-skelter. At first i noticed the hills/mnts % was not changing correctly and then inland water % was not changing, then the whole landmass was not in continents. Anyone? because with it gone it really makes maps not really fun to play.

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 26 Aug 2013 12:21:42 PM UTCjtnStatusNone=>Need Info
    Mon 26 Aug 2013 12:21:37 PM UTCjtnRelease2.4.0 RC1=>2.4.0-RC1
      SummaryNo FRACTAL map generator.=>Unwanted fallback from FRACTAL to RANDOM map generator
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup