bugFreeciv - Bugs: bug #21099, freeciv-manual assert failures due...

 
 
Show feedback again

bug #21099: freeciv-manual assert failures due to uninitialized settings

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue 03 Sep 2013 11:47:29 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.1, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 14 Sep 2013 11:03:49 PM UTC, SVN revision 23400:

Fixed freeciv-manual assert failures due to uninitialized settings.

See bug #21099

(Browse SVN revision 23400)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 14 Sep 2013 11:03:44 PM UTC, SVN revision 23399:

Fixed freeciv-manual assert failures due to uninitialized settings.

See bug #21099

(Browse SVN revision 23399)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 14 Sep 2013 11:03:38 PM UTC, SVN revision 23398:

Fixed freeciv-manual assert failures due to uninitialized settings.

See bug #21099

(Browse SVN revision 23398)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 04 Sep 2013 08:10:11 AM UTC, comment #2:

For the record, my main motive was not fixing freeciv-manual, but to make it possible to have such ruleset loading tools in general. I happily leave further freeciv-manual fixes to someone else.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 04 Sep 2013 08:04:27 AM UTC, comment #1:

Aha, you got further than I did in bug #21063, which started in the same place.

Morally the settings_init() is also missing from S2_3, although there it doesn't seem to be causing obvious harm.

Jacob Nevins <jtn>
Project Administrator
Tue 03 Sep 2013 11:47:29 PM UTC, original submission:

freeciv-manual gives several asserts (non-fatal) when run due to settings being uninitialized.

Fix attached.
Simply adding settings_init() call to freeciv-modpack was not enough, as that would cause aifill() for 5 players to be called as action of initializing aifill to default value. Parameter to control if in-game actions for setting adjustment should be done added.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18852:  ManualSettings.patch added by cazfi (10kB - text/x-diff)
file #18853:  ManualSettings-S2_5.patch added by cazfi (10kB - text/x-diff)
file #18854:  ManualSettings-S2_4.patch added by cazfi (8kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 14 Sep 2013 11:04:05 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 08 Sep 2013 12:23:16 PM UTCjtnDependencies-=>bugs #21063 is dependent
    Sun 08 Sep 2013 12:12:54 PM UTCjtnDependencies-=>bugs #21086 is dependent
    Tue 03 Sep 2013 11:47:29 PM UTCcazfiAttached File-=>Added ManualSettings.patch, #18852
      Attached File-=>Added ManualSettings-S2_5.patch, #18853
      Attached File-=>Added ManualSettings-S2_4.patch, #18854
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup