bugFreeciv - Bugs: bug #21143, send_unit_info_to_onlookers() puts...

 
 
Show feedback again

bug #21143: send_unit_info_to_onlookers() puts huge positive or negative values to 8 bits

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 16 Sep 2013 09:55:32 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.5,2.4.2,2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 03 Jan 2014 06:52:48 PM UTC, SVN revision 24003:

Always initialise activity targets for unit orders when loading
savegames, to avoid sending uninitialised garbage over the network
later.

Originally reported by Marko Lindqvist (cazfi@gna).

See gna bug #21143.

(Browse SVN revision 24003)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 03 Jan 2014 06:46:42 PM UTC, SVN revision 24000:

Always initialise activity targets for unit orders when loading
savegames, to avoid sending uninitialised garbage over the network
later.

Originally reported by Marko Lindqvist (cazfi@gna).

See gna bug #21143.

(Browse SVN revision 24000)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 03 Jan 2014 04:54:56 PM UTC, SVN revision 23997:

Always initialise activity targets for unit orders when loading
savegames, to avoid sending uninitialised garbage over the network
later.

Originally reported by Marko Lindqvist (cazfi@gna).

See gna bug #21143.

(Browse SVN revision 23997)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 03 Jan 2014 04:46:34 PM UTC, SVN revision 23994:

Always initialise activity targets for unit orders when loading
savegames, to avoid sending uninitialised garbage over the network
later.

Originally reported by Marko Lindqvist (cazfi@gna).

See gna bug #21143.

(Browse SVN revision 23994)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Thu 02 Jan 2014 03:32:36 AM UTC, comment #2:

Same underlying problem affects S2_4 and S2_3, but the warnings aren't present in those versions.

(file #19603, file #19604, file #19605)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Thu 02 Jan 2014 02:12:27 AM UTC, comment #1:

I've encountered this too -- trunk savegame attached. In this game, an example of a unit triggering this is id 792, English Freight with goto orders.

The problem for me seems to be that when loading from savegame, activity target is not initialised for orders where it's not relevant, but the uninitialsed garbage is unconditionally sent to the client, hence the noise.

Working on patches now.

(file #19598)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 16 Sep 2013 09:55:32 PM UTC, original submission:

"Trying to put -1061625928 into 8 bits" repeated many times with different values when restarting our multiplayer game from savegame. Backtrace shows send_unit_info_to_onlookers() called by send_all_known_units() called by send_all_info().

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19603:  trunk-savegame-init-orders.patch added by jtn (3kB - text/x-diff - trunk/S2_5/S2_4/S2_3 r23974)
file #19604:  S2_5-savegame-init-orders.patch added by jtn (1006B - text/x-diff - trunk/S2_5/S2_4/S2_3 r23974)
file #19605:  S2_4-S2_3-savegame-init-orders.patch added by jtn (726B - text/x-diff - trunk/S2_5/S2_4/S2_3 r23974)
file #19598:  teamgame2.sav.bz2 added by jtn (41kB - application/x-bzip - trunk r23942 savegame showing problem)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 03 Jan 2014 06:54:22 PM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 02 Jan 2014 03:32:36 AM UTCjtnAttached File-=>Added trunk-savegame-init-orders.patch, #19603
      Attached File-=>Added S2_5-savegame-init-orders.patch, #19604
      Attached File-=>Added S2_4-S2_3-savegame-init-orders.patch, #19605
      StatusIn Progress=>Ready For Test
      Planned Release=>2.3.5,2.4.2,2.5.0,2.6.0
    Thu 02 Jan 2014 02:12:27 AM UTCjtnAttached File-=>Added teamgame2.sav.bz2, #19598
      StatusNone=>In Progress
      Assigned toNone=>jtn
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup