bugFreeciv - Bugs: bug #21155, City settings for new citizens

 
 
Show feedback again

bug #21155: City settings for new citizens

Submitted by:  None
Submitted on:  Sun 22 Sep 2013 02:24:38 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: OpenRelease: 
Operating System: AnyPlanned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 03 Nov 2013 12:15:53 PM UTC, comment #2:

The client city options are enacted in city_increase_size(), which subsequently calls auto_arrange_workers(). Can the selection of specialists survive this, or is it completely futile?

If so, the bug would be "city specialist preference completely ignored", and the observed change in behaviour between 2.3 and 2.4 might be down to us fixing the "unwanted tax collectors" bug (patch #3620 and friends).

(I did wonder if the translation of CITYO_NEW_TAXMAN as best_specialist(O_GOLD, pcity) might yield the wrong result, but adding debug logging to 2.4.0 shows that it chooses Taxmen, yet my test city ended up with only entertainers / scientists.)

Jacob Nevins <jtn>
Project Administrator
Sun 03 Nov 2013 10:12:00 AM UTC, comment #1:

Another similar report in bug #21234 (against 2.4.0 on Windows):

> 2) client ignores "new citizens are" setting in city tab
> new citizens are made always scientists even when setting is on "taxeman"
> it also changes all taxemans to scientists on city growth (entertainers stay same)

Jacob Nevins <jtn>
Project Administrator
Sun 22 Sep 2013 02:24:38 PM UTC, original submission:

The city "settings" for "new citizens" do not more work as expected.

General behaviour: If a city has no governor and grows, or if the user double-clicks on the city centre in the mini-map, the citizens are automatically reset for an optimal output. Some citizens will be entertainers (= produce happiness) to balance unhappy citizens. Other citizens work on tiles to produce food, shields, or trade points.

Old behaviour: All remaining citizens worked as entertainers, scientists, or taxmen determined per city by the settings for "new citizen". The default "entertainer" was rather dubious.

New behaviour (introduced before 2.3.4): All remaining citizens work as scientists. The settings for "new citizens" is ignored. This is typically better than the old behaviour; it is not more necessary to change the default "entertainer" to "scientist" for each city.

However, after researching everything, "scientists" are less interesting than "taxmen", and changing the settings for "new citizens" to "taxmen" does not more work as expected.

Suggested fixes:
(1) Revert to the old behaviour with a new default "scientists" instead of "entertainers".
(2) Replace the old per city settings for "new citizens" by global settings, with a default "scientists". Players could then simply switch to taxmen or entertainers for new citizens in all cities.

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup