bugFreeciv - Bugs: bug #21161, human team player changes my...

 
 
Show feedback again

bug #21161: human team player changes my research goal

Submitted by:  taka <taka>
Submitted on:  Tue Sep 24 23:17:35 2013  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: 2.3.4Operating System: Microsoft Windows
Planned Release: 2.4.3,2.5.0,2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu May 22 17:14:50 2014, SVN revision 24924:

Don't assume that player research is shared for the whole team and that every
player has its own structure for it.

From a report by taka@gna

See gna bug #21160 and bug #21161

(Browse SVN revision 24924)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu May 22 17:14:46 2014, SVN revision 24923:

Don't assume that player research is shared for the whole team and that every
player has its own structure for it.

From a report by taka@gna

See gna bug #21160 and bug #21161

(Browse SVN revision 24923)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu May 22 17:14:41 2014, SVN revision 24922:

Don't assume that player research is shared for the whole team and that every
player has its own structure for it.

From a report by taka@gna

See gna bug #21160 and bug #21161

(Browse SVN revision 24922)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue May 20 16:36:35 2014, comment #8:

Actually, all the bugs (case1, case2 and bug #21160) have exactly the same cause. Only the consequences are different.

So my patch also fix bug #21160.

pepeto <pepeto>
Project MemberIn charge of this item.
Tue May 20 15:51:52 2014, comment #7:

I think that Gna bug #21160 is dependent on this bug (case2)

taka <taka>
Tue May 20 15:34:16 2014, comment #6:

They were some pieces of code which was still considering that research was shared by team. Changing tech goal was one of them (it was also considering that the player_research structure was different for every team mate).

When you change the technology goal to "Map Making", it works. But, it causes that your team mate changes also his tech goal to "Map Making" which is impossible because he already knows this tech. So "None" is set for him, and because he changed his goal to "None", you changed too for it...

I don't understand how I failed to reproduce the bug.

Fix attached (notice that it corrects also some other pieces of code assuming team pooled research is enabled).

(file #20776)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue May 20 15:00:59 2014, comment #5:

I can easily reproduce with the savegame. Thank you very much.

pepeto <pepeto>
Project MemberIn charge of this item.
Tue May 20 13:53:46 2014, comment #4:

http://fast-uploader.com/file/6956145542597/
Replay video (FLV file, 23M) will be deleted in one month.

Time 0:20- Game Settings
taka and Haut is teamed, but team_pooled_research is disabled.

Time 2:00- case1
taka want to set technology goal to Mathematics.
But Haut can change taka's technology goal to Monarchy/Trade.

Time 7:40- case2
Haut completed Map Maing research.
then taka cannot select Map Making for technology goal.

taka <taka>
Sun May 18 16:28:57 2014, comment #3:

I can't reproduce. Is there any extra option set. Could you provide a savegame?

pepeto <pepeto>
Project MemberIn charge of this item.
Sun Dec 8 01:51:53 2013, comment #2:

We needs two or above human teamed player if you want to confirm it.
I think commment #1 is bug, but original submission is not bug.

taka <taka>
Tue Sep 24 23:22:25 2013, comment #1:

and I can't set the Research goal to any tech
which had been reserched for team player.

taka <taka>
Tue Sep 24 23:17:35 2013, original submission:

Research goal is shared despite team_pooled_research is disabled.

taka <taka>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20776:  not_pooled_research.patch added by pepeto (3kB - text/x-patch)
file #20774:  bug21161.sav.bz2 added by taka (13kB - application/x-bzip2)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by taka (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Oct 6 22:51:08 2014jtnSummaryhuman team player changes my reserch goal=>human team player changes my research goal
    Thu May 22 17:15:20 2014pepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue May 20 15:34:16 2014pepetoAttached File-=>Added not_pooled_research.patch, #20776
      CategoryNone=>general
      StatusConfirmed=>Ready For Test
      Assigned toNone=>pepeto
      Planned Release=>2.4.3,2.5.0,2.6.0
    Tue May 20 15:00:59 2014pepetoStatusNone=>Confirmed
    Tue May 20 13:55:38 2014takaAttached File-=>Added bug21161.sav.bz2, #20774
    Tue Sep 24 23:33:03 2013cazfiCategoryclient-win32=>None
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup