bugFreeciv - Bugs: bug #21163, Freeciv theme applied at first at...

 
 
Show feedback again

bug #21163: Freeciv theme applied at first at start even if prefs has another theme

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 26 Sep 2013 12:15:02 PM UTC  
 
Category: client-gtk-2.0Severity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Christian Prochaska <cproc>Open/Closed: Closed
Release: 2.4.0Operating System: Microsoft Windows
Planned Release: 2.4.1, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 24 Nov 2013 01:19:39 AM UTC, SVN revision 23768:

Build GTK+3 Windows installer package

See task #7681.
Also fixes bug #21163.

(Browse SVN revision 23768)

Christian Prochaska <cproc>
Project AdministratorIn charge of this item.
Sun 24 Nov 2013 01:19:16 AM UTC, SVN revision 23767:

Build GTK+3 Windows installer package

See task #7681.
Also fixes bug #21163.

(Browse SVN revision 23767)

Christian Prochaska <cproc>
Project AdministratorIn charge of this item.
Sun 24 Nov 2013 01:18:00 AM UTC, SVN revision 23766:

Build GTK+3 Windows installer package

See task #7681.
Also fixes bug #21163.

(Browse SVN revision 23766)

Christian Prochaska <cproc>
Project AdministratorIn charge of this item.
Sun 29 Sep 2013 11:14:55 PM UTC, comment #4:

I can't think of anything until theme loading is implemented to freeciv-modpack itself. So we have to choose between having freeciv theme on freeciv-modpack, and client theme selection working?
In no other environment freeciv-modpack uses freeciv theme. It's utility separate enough that sharing theme with freeciv, the game, is not crucial.

Marko Lindqvist <cazfi>
Project Administrator
Fri 27 Sep 2013 12:14:11 AM UTC, comment #3:

The gtkrc file is used to set the Freeciv theme for the modpack installer. Do you perhaps know a simple alternative way to achieve that?

Christian Prochaska <cproc>
Project AdministratorIn charge of this item.
Thu 26 Sep 2013 01:20:41 PM UTC, comment #2:

Problem is that Freeciv theme is set as system wide default in our windows installer packages. So the "reset to default + apply new theme" actually is "apply Freeciv + apply new theme".

Simply removing etc/gtk-2.0/gtkrc works for me.

Marko Lindqvist <cazfi>
Project Administrator
Thu 26 Sep 2013 12:47:41 PM UTC, comment #1:

- I cannot reproduce on Linux, even with same themes (or themes with the same name) are involved
- Switching to "Amaranth" theme handles the backgound too, but even if I switch directly from "Amaranth" to some other theme, Freeciv background appears.

Marko Lindqvist <cazfi>
Project Administrator
Thu 26 Sep 2013 12:15:02 PM UTC, original submission:

Testing theme switching in Windows I found out that no matter what I do - including client restart - some parts (background image at least) of the Freeciv theme remain. The only explanation I can think about is that other themes do not overwrite everything that Freeciv sets, and thus Freeciv properties come through. I don't know if we can do anything to that while switching theme in running game, but if one starts freeciv with theme other than Freeciv, that theme should be applied on top of no-theme (or default theme) rather than Freeciv theme, i.e., Freeciv theme should not be applied at all.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cproc (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 24 Nov 2013 01:22:11 AM UTCcprocStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Thu 26 Sep 2013 01:26:12 PM UTCcazfiAssigned toNone=>cproc
    Thu 26 Sep 2013 01:20:41 PM UTCcazfiOperating SystemNone=>Microsoft Windows
      Planned Release=>2.4.1, 2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup