bugFreeciv - Bugs: bug #21206, nation_group_by_number()...

 
 
Show feedback again

bug #21206: nation_group_by_number() out-of-bounds check can never fire

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Mon 21 Oct 2013 07:59:31 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.3.5,2.4.1,2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 23 Oct 2013 09:41:37 AM UTC, SVN revision 23619:

Fix nation_group_by_number() handling of out-of-range index.

See gna bug #21206.

(Browse SVN revision 23619)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 23 Oct 2013 09:41:16 AM UTC, SVN revision 23617:

Fix nation_group_by_number() handling of out-of-range index.

See gna bug #21206.

(Browse SVN revision 23617)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 23 Oct 2013 09:40:44 AM UTC, SVN revision 23615:

Fix nation_group_by_number() handling of out-of-range index.

See gna bug #21206.

(Browse SVN revision 23615)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 23 Oct 2013 09:34:00 AM UTC, SVN revision 23613:

Fix nation_group_by_number() handling of out-of-range index.

See gna bug #21206.

(Browse SVN revision 23613)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 21 Oct 2013 07:59:31 PM UTC, original submission:

Spot the deliberate mistake in this out-of-bounds check:

Fortunately nothing currently relies on this being trapped (at least on trunk, not thoroughly checked other branches).

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19220:  trunk-S2_5-S2_4-S2_3-nation_group_by_number.patch added by jtn (707B - text/x-diff - trunk/S2_5/S2_4/S2_3 r23609)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Oct 2013 09:49:26 AM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 21 Oct 2013 08:28:07 PM UTCjtnAttached File-=>Added trunk-S2_5-S2_4-S2_3-nation_group_by_number.patch, #19220
      StatusIn Progress=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup