bugFreeciv - Bugs: bug #21207, Server keeps "Not enough...

 
 
Show feedback again

bug #21207: Server keeps "Not enough nations for players" message to itself

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Mon 21 Oct 2013 08:04:06 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.3.5,2.4.1,2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 23 Oct 2013 09:41:40 AM UTC, SVN revision 23620:

Ensure connections get notified if game fails to start for lack of nations.

See gna bug #21207.

(Browse SVN revision 23620)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 23 Oct 2013 09:41:20 AM UTC, SVN revision 23618:

Ensure connections get notified if game fails to start for lack of nations.

See gna bug #21207.

(Browse SVN revision 23618)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 23 Oct 2013 09:40:49 AM UTC, SVN revision 23616:

Ensure connections get notified if game fails to start for lack of nations.

See gna bug #21207.

(Browse SVN revision 23616)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 23 Oct 2013 09:34:04 AM UTC, SVN revision 23614:

Ensure connections get notified if game fails to start for lack of nations.

See gna bug #21207.

(Browse SVN revision 23614)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 21 Oct 2013 08:04:06 PM UTC, original submission:

start_command() has a check that there are enough playable nations for all the players, with an associated failure message "Not enough nations for all players; game will not start."

Unfortunately, unlike other failures, for some reason it doesn't use notify_conn() to emit this message, only cmd_reply(). Since this code is typically invoked in response to a PLAYER_READY packet, no-one sees the message (except the server console).

Not sure how you can get into this situation currently (but I'm about to create a way in patch #3448, which is how I noticed).

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19221:  trunk-S2_5-S2_4-S2_3-not-enough-nations-msg.patch added by jtn (1kB - text/x-diff - trunk/S2_5/S2_4/S2_3 r23609)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Oct 2013 09:49:32 AM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 21 Oct 2013 08:28:21 PM UTCjtnAttached File-=>Added trunk-S2_5-S2_4-S2_3-not-enough-nations-msg.patch, #19221
      StatusIn Progress=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup