bugBattle for Wesnoth - Bugs: bug #21214, MP Statistics wrongly lumps...

 
 
Show feedback again

bug #21214: MP Statistics wrongly lumps together all sides' recruits, kills, and losses

Submitted by:  Gregory Gauthier <rjaguar3>
Submitted on:  Thu Oct 24 03:16:39 2013  
 
Category: BugSeverity: 5 - Blocker
Priority: 4Item Group: Multiplayer
Status: FixedPrivacy: Public
Assigned to: Andrius Silinskas <thunderstruck>Open/Closed: Closed
Release: 1.11.6+dev (e9fd0d5)Operating System: Linux Mint 14

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri Dec 27 16:11:54 2013, comment #12:

I tested it, and the bug seems fixed now.

George <wintermute>
Project Member
Fri Dec 27 13:48:27 2013, comment #11:

I've partially reverted (c8f861cee410c2921be8904a81f545a0c9fd272a) a commit which introduces this bug and I must admit that it was a silly mistake I did. The bug should be fixed now.

Andrius Silinskas <thunderstruck>
Project MemberIn charge of this item.
Sun Dec 22 13:09:47 2013, comment #10:

I'll be able to look at it some time in the next few days. If that's not good enough, the commit which introduces this bug could be reverted.

Andrius Silinskas <thunderstruck>
Project MemberIn charge of this item.
Sat Dec 21 23:52:17 2013, comment #9:

Marked as a blocker pending khalifate inclusion. If the khalifate are going to be added then we expect more server traffic on the development branch server - and this bug is really bad for serious multiplayer games. If the khalifate are not going to be included then it could probably be relegated to important for now - but surely it needs to be fixed before a stable release.

George <wintermute>
Project Member
Sat Dec 21 02:42:20 2013, comment #8:

The bug was introduced in commit e45df51a. Reverting the commit appears to fix the bug.

Gregory Gauthier <rjaguar3>
Wed Dec 18 04:04:44 2013, comment #7:

Yep, sorry - I should have checked more closely, I was noticing while playing and wanted to note it before I forgot.

George <wintermute>
Project Member
Wed Dec 18 03:22:23 2013, comment #6:

Well, yeah. The status is "none". If it was fixed, the status would be fixed.

If you want it fixed faster, you are welcome to submit a patch.

J Tyne <jamit>
Project Member
Wed Dec 18 02:56:45 2013, comment #5:

Still broken in 1.11.7 and presumably trunk. This is bad news for anyone who wants to play multiplayer.

George <wintermute>
Project Member
Sun Nov 24 13:43:31 2013, comment #4:

This bug actually has game-breaking possibilities. In local multiplayer at least (I haven't checked whether the exploit works on the server), a player can use the statistics window to find out exactly what the opponent has recruited (and, by implication, what faction the opponent is playing when the opponent has chosen "random") even when he shouldn't know that information.

Gregory Gauthier <rjaguar3>
Tue Nov 5 01:33:00 2013, comment #3:

OK, I probably messed up somewhere. I'll assign this to myself to remind me to look into this when I finish my current project.

J Tyne <jamit>
Project Member
Mon Nov 4 13:56:46 2013, comment #2:

I just checked; the statistics are fine in 1.10.4.

Gregory Gauthier <rjaguar3>
Sun Nov 3 19:55:34 2013, comment #1:

Is it working in 1.10?

J Tyne <jamit>
Project Member
Thu Oct 24 03:16:39 2013, original submission:

See the attached screenshots. Notice also the damage statistics appear to be bugged. The replay is also attached. Note that I played Knalgans against AI's loyalists.

Gregory Gauthier <rjaguar3>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19225:  2p_—_Sulla’s_Ruins_replay_B.gz added by rjaguar3 (21kB - application/x-gzip)
file #19226:  wesnoth-stats-bug.zip added by rjaguar3 (710kB - application/x-zip-compressed)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by thunderstruck (Posted a comment)
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by wintermute (Posted a comment)
  • -unavailable- added by jamit (Posted a comment)
  • -unavailable- added by rjaguar3 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Jan 6 00:21:44 2014shadowmasterOpen/ClosedOpen=>Closed
    Fri Dec 27 16:11:54 2013wintermuteStatusReady For Test=>Fixed
    Fri Dec 27 13:49:00 2013thunderstruckStatusNone=>Ready For Test
    Sat Dec 21 23:52:17 2013wintermuteSeverity4 - Important=>5 - Blocker
    Sat Dec 21 03:07:05 2013shadowmasterAssigned tojamit=>thunderstruck
    Wed Dec 18 21:50:59 2013wintermuteSeverity3 - Normal=>4 - Important
    Tue Nov 5 01:33:00 2013jamitPriority5 - Normal=>4
      Assigned toNone=>jamit
    Thu Oct 24 03:16:39 2013rjaguar3Attached File-=>Added 2p_—_Sulla’s_Ruins_replay_B.gz, #19225
      Attached File-=>Added wesnoth-stats-bug.zip, #19226
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup