bugFreeciv - Bugs: bug #21231, Plrcolor assert failures/crashes...

 
 
Show feedback again

bug #21231: Plrcolor assert failures/crashes when tileset suggested by ruleset accepted

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 26 Oct 2013 05:23:28 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: S2_4Operating System: None
Planned Release: 2.4.1, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 28 Oct 2013 10:29:27 PM UTC, SVN revision 23644:

If tileset reload is called in the middle of ruleset initialization,
do not try to handle player colors. They will be handled later in the game startup.
This fixes crash when user accepts tileset suggestion from ruleset.

See bug #21231

(Browse SVN revision 23644)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 28 Oct 2013 10:29:19 PM UTC, SVN revision 23643:

If tileset reload is called in the middle of ruleset initialization,
do not try to handle player colors. They will be handled later in the game startup.
This fixes crash when user accepts tileset suggestion from ruleset.

See bug #21231

(Browse SVN revision 23643)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 28 Oct 2013 10:29:13 PM UTC, SVN revision 23642:

If tileset reload is called in the middle of ruleset initialization,
do not try to handle player colors. They will be handled later in the game startup.
This fixes crash when user accepts tileset suggestion from ruleset.

See bug #21231

(Browse SVN revision 23642)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 26 Oct 2013 07:29:44 PM UTC, comment #3:

Patch

If tileset reload is called in the middle of ruleset initialization, do not handle player colors - they will be handled later in the game startup.

(file #19250)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 26 Oct 2013 06:02:57 PM UTC, comment #2:

That explains the one crash I'm getting from tileset_background_init() called by tilespec_reread()
Other plrcolor problems are probably similar in that things are not yet initialized.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 26 Oct 2013 05:58:30 PM UTC, comment #1:

game.plr_bg_color is set (after being initialized to NULL) in handle_rulese_game(). Tileset suggestion is handled already before that, in handle_ruleset_control()

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 26 Oct 2013 05:23:28 PM UTC, original submission:

forum.freeciv.org/f/viewtopic.php?f=11&t=132&p=992

- Download nextended modpack
- Launch separate server and /rulesetdir nextended
- Launch client with default tileset
- Connect client to server
- "Load Tileset" when switching tileset is suggested

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Oct 2013 10:29:45 PM UTCcazfiStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 26 Oct 2013 07:29:44 PM UTCcazfiAttached File-=>Added TilesetReloadPartialState.patch, #19250
      StatusIn Progress=>Ready For Test
    Sat 26 Oct 2013 06:25:27 PM UTCcazfiStatusNone=>In Progress
      Assigned toNone=>cazfi
      Planned Release=>2.4.1, 2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup