bugFreeciv - Bugs: bug #21240, AI thinking city has Size Unlimit...

 
 
Show feedback again

bug #21240: AI thinking city has Size Unlimit when it has not

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 30 Oct 2013 10:22:21 AM UTC  
 
Category: aiSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.1, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 20 Nov 2013 11:19:52 PM UTC, SVN revision 23758:

When evaluating Size_Unlimit or Size_Adjust effect value, do not assume that
city with negative Size_Unlimit already has unlimited size. Also do not consider
effect disabling Size_Unlimit positive thing.

See bug #21240

(Browse SVN revision 23758)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 20 Nov 2013 11:19:47 PM UTC, SVN revision 23757:

When evaluating Size_Unlimit or Size_Adjust effect value, do not assume that
city with negative Size_Unlimit already has unlimited size. Also do not consider
effect disabling Size_Unlimit positive thing.

See bug #21240

(Browse SVN revision 23757)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 20 Nov 2013 11:19:39 PM UTC, SVN revision 23756:

When evaluating Size_Unlimit or Size_Adjust effect value, do not assume that
city with negative Size_Unlimit already has unlimited size. Also do not consider
effect disabling Size_Unlimit positive thing.

See bug #21240

(Browse SVN revision 23756)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 30 Oct 2013 10:22:21 AM UTC, original submission:

AI checks if city already has size unlimited by comparing effect value == 0. In custom rulesets with only disabling effects active (without prior enabling effect) value can be < 0. In such a case AI would not build size adj or size unlimit buildings at all.

Fix attached. Also don't consider Size Unlimit disabling effects positive thing (equal to enabling effects)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19292:  SizeUnlimitFix.patch added by cazfi (1kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 20 Nov 2013 11:20:02 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 30 Oct 2013 10:22:21 AM UTCcazfiAttached File-=>Added SizeUnlimitFix.patch, #19292
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup