bugFreeciv - Bugs: bug #21243, Broken desktopfile installed for...

 
 
Show feedback again

bug #21243: Broken desktopfile installed for non-default gtk-client

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 31 Oct 2013 10:44:21 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.1, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 16 Nov 2013 11:46:30 AM UTC, SVN revision 23741:

Add new .desktop files from bug #21243 to svn:ignore.

(Browse SVN revision 23741)

Jacob Nevins <jtn>
Project Administrator
Sat 16 Nov 2013 11:43:47 AM UTC, SVN revision 23739:

Add new .desktop files from bug #21243 to svn:ignore.

(Browse SVN revision 23739)

Jacob Nevins <jtn>
Project Administrator
Fri 15 Nov 2013 10:12:16 PM UTC, SVN revision 23733:

Fixed installation of gtk2- and gtk3-client desktopfiles when there's
more than one client built.

Reported by Jacob Nevins

See bug #21243

(Browse SVN revision 23733)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 15 Nov 2013 10:10:27 PM UTC, comment #8:

TRUNK is the only branch affected by that mistake. Will commit attached fix immediately.

(file #19354)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 11 Nov 2013 09:48:38 PM UTC, comment #7:

> I'm guessing some of the existing "desktopfile_DATA = " needed
> changing to +=?


Yes, some of them are "=" accidentally. Who ever has time to fix this first, feel free to commit the fix immediately as build fix.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 11 Nov 2013 08:56:49 PM UTC, comment #6:

Getting the following warnings when I do autogen.sh from head of trunk; I'm guessing this change is implicated:

I'm guessing some of the existing "desktopfile_DATA = " needed changing to +=?

Jacob Nevins <jtn>
Project Administrator
Mon 11 Nov 2013 12:23:43 AM UTC, SVN revision 23720:

Added desktop files for gtk3-, and sdl-clients.

See bug #21243

(Browse SVN revision 23720)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 11 Nov 2013 12:23:19 AM UTC, SVN revision 23719:

Added desktop files for gtk2-, qt-, and sdl-clients.

See bug #21243

(Browse SVN revision 23719)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 11 Nov 2013 12:22:50 AM UTC, SVN revision 23718:

Added desktop files for gtk2-, qt-, sdl-, and sdl2-clients.

See bug #21243

(Browse SVN revision 23718)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 31 Oct 2013 05:14:04 PM UTC, comment #2:

- Mention type of the client in name shown from desktop file, so user can tell them apart when multiple installed

(file #19305, file #19306, file #19307)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 31 Oct 2013 11:14:44 AM UTC, comment #1:

Mostly untested patches to add desktop files for various clients.

S2_4: gtk3, sdl
S2_5: gtk2, sdl, qt
TRUNK: gtk2, sdl, qt, sdl2

(file #19300, file #19301, file #19302)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 31 Oct 2013 10:44:21 AM UTC, original submission:

freeciv.desktop is installed when ever either gtk2- or gtk3-client is. The desktop-file contains name of the binary to run. That's default client, freeciv-gtk2 in S2_4, and freeciv-gtk3 in S2_5/TRUNK. Desktop file does not work for the other kind of the client.

Obvious solution is the one that I were already doing when I discovered this bug: provide separate desktop file for each client.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19354:  DesktopfileAddFix.patch added by cazfi (507B - text/x-diff)
file #19300:  ClientDesktopFiles.patch added by cazfi (7kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Nov 2013 10:10:27 PM UTCcazfiAttached File-=>Added DesktopfileAddFix.patch, #19354
    Mon 11 Nov 2013 12:23:53 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 31 Oct 2013 05:14:04 PM UTCcazfiAttached File-=>Added ClientDesktopFiles-2.patch, #19305
      Attached File-=>Added ClientDesktopFiles-S2_5-2.patch, #19306
      Attached File-=>Added ClientDesktopFiles-S2_4-2.patch, #19307
    Thu 31 Oct 2013 11:14:44 AM UTCcazfiAttached File-=>Added ClientDesktopFiles.patch, #19300
      Attached File-=>Added ClientDesktopFiles-S2_5.patch, #19301
      Attached File-=>Added ClientDesktopFiles-S2_4.patch, #19302
      StatusIn Progress=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup