bugFreeciv - Bugs: bug #21263, get_tileset_list() (used in local...

 
 
Show feedback again

bug #21263: get_tileset_list() (used in local settings dialog) has side effects

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Thu 07 Nov 2013 12:36:50 AM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: Any
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 07 Nov 2013 12:36:50 AM UTC, original submission:

Split from bug #21151 / bug #21116:

get_tileset_list() repeatedly calls tileset_read_toplevel() to get a list of tilesets. However, it's documented as having side-effects, and whether or not those comments are correct, it certainly calls set_city_names_font_sizes() which has global side-effects.

Dunno whether that's best considered a bug in tileset_read_toplevel(). Maybe there's a less invasive way to enumerate the existing tilesets?

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup