bugBattle for Wesnoth - Bugs: bug #21289, Replays in 1.11 do not play...

 
 
Show feedback again

bug #21289: Replays in 1.11 do not play through prestart and start events

Submitted by:  Matthias Schoeck <mattsc>
Submitted on:  Wed 20 Nov 2013 10:04:49 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Replays
Status: FixedPrivacy: Public
Assigned to: Matthias Schoeck <mattsc>Open/Closed: Closed
Release: 1.11.7Operating System: OS X 10.8

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 22 Nov 2013 03:16:01 AM UTC, comment #1:

Fixed in commit 2cb96755e43cf837de789fc879817627e34fcf18.

As a side note, in a separate commit I also fixed an unreported bug that disables the replay play/stop buttons again (as it was before) when the end of the replay is reached.

Matthias Schoeck <mattsc>
Project MemberIn charge of this item.
Wed 20 Nov 2013 10:04:49 PM UTC, original submission:

To reproduce, start any scenario with prestart/start events, such as the messages at the beginning of most any mainline scenario. Save the replay, then reload it. The replay will start after the messages (and any other actions in those two events). This is contrary to the behavior in 1.10 and means important information might be missing from the replay.

The reason for this is that the replay_start gamestate is saved after the start event. This means that firing [pre]start events by the replay might, for example, duplicate units, as reported here. Thus, the prestart and start events have been disabled.

In my opinion, this is the wrong way around. Instead, the gamestate should be saved before the prestart event and the events should be fired.

I can fix this, but I would like to know first whether there is a reason for the current behavior that I might be missing.

Matthias Schoeck <mattsc>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by mattsc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 06 Jan 2014 12:20:59 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Fri 22 Nov 2013 03:16:01 AM UTCmattscAssigned toNone=>mattsc
    Fri 22 Nov 2013 03:16:00 AM UTCmattscStatusNone=>Fixed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup