bugBattle for Wesnoth - Bugs: bug #21290, Unit names and ids are not synced...

Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #21290: Unit names and ids are not synced in MP and replays

Submitted by:  Matthias Schoeck <mattsc>
Submitted on:  Wed Nov 20 22:43:48 2013  
Category: BugSeverity: 3 - Normal
Priority: 3 - LowItem Group: Units
Status: FixedPrivacy: Public
Assigned to: Matthias Schoeck <mattsc>Open/Closed: Closed
Release: 1.11.7Operating System: OS X 10.8

Mon Nov 25 02:26:00 2013, comment #1:

The names are now synced as of commit 071b7550f9cf1fafb0d46a7c9f3704de0d8bc737. While doing that I noticed that unit genders were also not synced. That has also been fixed.

Also, I changed my mind about this problem not causing OOS errors. It was, in fact, quite easy to come up with test cases that caused OOS errors before names and genders were synced.

ids and underlying_ids are not synced yet and there is some question as to whether that's necessary.

Matthias Schoeck <mattsc>
Project MemberIn charge of this item.
Wed Nov 20 22:43:48 2013, original submission:

Take any replay and play a turn in which units are recruited. Take note of the names of the recruited units. Then play the same replay turn again. The names are now different, as are the unit ids (and underlying_ids, in fact).

The same is true for the units in a MP game. Each player will see different names for units that do not have assigned names.

We propose to fix this and have at least the names synced for replays and MP games. It does likely not cause OOS errors (as these attributes are only accessible by extracting them from the unit first and each host/client/replay will do this correctly for its own situation), but at the very least it seems inelegant to have the same units in a MP game have different names for different players.

Matthias Schoeck <mattsc>
Project MemberIn charge of this item.


No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by gfgtdf (Updated the item)
  • -unavailable- added by mattsc (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Aug 8 23:31:27 2016gfgtdfStatusNone=>Fixed
    Mon Nov 25 02:26:00 2013mattscAssigned toNone=>mattsc
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup