bugFreeciv - Bugs: bug #21296, Savegame loading doesn't honour...

Show feedback again

bug #21296: Savegame loading doesn't honour REVEAL_MAP_DEAD

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 23 Nov 2013 08:47:25 PM UTC  
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: Any
Planned Release: 2.5.4, 2.6.0, 3.0.0

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Thu 21 Jan 2016 05:15:16 AM UTC, comment #1:

Even if we can't show correct map for dead players, the intention of disabled REVEAL_MAP_DEAD is clearly to prohibit knowledge leak -> it would be better to show nothing than everything.

Marko Lindqvist <cazfi>
Project Administrator
Sat 23 Nov 2013 08:47:25 PM UTC, original submission:

In savegame.c:player_load_vision() and savegame2.c:sg_load_player_vision(), map_know_and_see_all() is called unconditionally for dead players, even if the 'revealmap' option doesn't allow dead players to see the map.

(Also, the normal check in kill_player() prevents the map being revealed for dead members of teams; again, this doesn't seem to be checked here.)

The system seems to take full advantage of the assumption that dead players get to see the whole map (as they always used to): savegame2.c:sg_save_player_vision() doesn't bother to save anything for dead players. So, the fix isn't straightforward; there'll need to be special handling for old savegames.
(I don't know if there's some reason it's hard to save the player map for dead players -- perhaps stuff was thrown away or became invalid when they died?)

Jacob Nevins <jtn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 03 Feb 2016 11:53:53 PM UTCcazfiPlanned Release2.5.3, 2.6.0, 3.0.0=>2.5.4, 2.6.0, 3.0.0
    Thu 21 Jan 2016 05:15:16 AM UTCcazfiPlanned Release=>2.5.3, 2.6.0, 3.0.0
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup