bugFreeciv - Bugs: bug #21317, Empty server shows up on...

 
 
Show feedback again

bug #21317: Empty server shows up on metaserver as Humans="Unknown"

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 01 Dec 2013 12:51:55 AM UTC  
 
Category: NoneSeverity: 2 - Minor
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: Any
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 01 Dec 2013 12:51:55 AM UTC, original submission:

Tiny thing that's been bothering me for ages...

I've noticed that on http://meta.freeciv.org/ sometimes server show up as having "Human Players" = "Unknown", despite being a new enough version (post patch #2312) that they should know about humans. This has made me not quite trust that column at all.

Now I come to investigate, it happens when a server has no players at all (even AI), because in this case the server sends the special "dropplrs" signal to the metaserver and doesn't include the "humans" / "available" counts. So the metaserver can't know that this server counts humans.

Proposed backward-compatible solution:

  • In the server, always send "humans" (and maybe "available") even if there are no players and we're sending "dropplrs". (I think old metaservers will ignore this.)
  • In the metaserver, if the incoming request from a server includes "humans" (and maybe "available"?), honour it (or at least set "humans" to 0 rather than -1). (Old servers will give the current behaviour.)
Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup