bugFreeciv - Bugs: bug #21326, You already had a city called...

 
 
Show feedback again

bug #21326: You already had a city called Helsinki. The city was renamed to Helsinki.

Submitted by:  log65536 <log65536>
Submitted on:  Wed 04 Dec 2013 11:28:07 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 05 Dec 2013 08:29:44 PM UTC, comment #2:

> Possible fixes are to make the client honour the 'name='
> property of links more often, or to defer the notify_player()
> on the server to later in transfer_city() (probably after the
> call to send_city_info())?


What about using "[l ...]Valencia[/l]" in this case ?

pepeto <pepeto>
Project Member
Thu 05 Dec 2013 12:18:47 AM UTC, comment #1:

> My guess is that city_link() creates the link correctly to the
> city now called Valencia, but the client processes this link by
> city id rather than by name, and thus uses the old name.

Spot on. See common/featured_text.c:text_tag_replace_text().

This kind of makes sense for units (as it can translate the name into the reader's language), but that doesn't really apply to city names. And I think the correct name will be provided in the link as a '[l tgt=city ... name="Valencia"]', which makes it a bit silly to get this wrong!

Possible fixes are to make the client honour the 'name=' property of links more often, or to defer the notify_player() on the server to later in transfer_city() (probably after the call to send_city_info())?

Jacob Nevins <jtn>
Project Administrator
Wed 04 Dec 2013 11:28:07 AM UTC, original submission:

I got this message when I captured an enemy's Helsinki and the server automatically renamed it to Valencia, because I already had another city called Helsinki.

The bug sounded trivial, so I decided to investigate:

My guess is that city_link() creates the link correctly to the city now called Valencia, but the client processes this link by city id rather than by name, and thus uses the old name.

Unfortunately, I am not familiar enough with the code to investigate further.

log65536 <log65536>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by log65536 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup