bugFreeciv - Bugs: bug #21329, Whitespace above units too large...

 
 
Show feedback again

bug #21329: Whitespace above units too large in city overview window

Submitted by:  None
Submitted on:  Thu 05 Dec 2013 03:28:53 AM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Originator Email: -unavailable-
Open/Closed: ClosedRelease: 2.4
Operating System: GNU/LinuxPlanned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 01 Jan 2014 11:16:24 PM UTC, SVN revision 23974:

Have "full tile height" of non-iso hex tilesets to be "normal tile height" only,
drastically cutting need to have extra spacing in sprites.

Reported by Anonymous

See bug #21329

(Browse SVN revision 23974)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 01 Jan 2014 11:16:19 PM UTC, SVN revision 23973:

Have "full tile height" of non-iso hex tilesets to be "normal tile height" only,
drastically cutting need to have extra spacing in sprites.

Reported by Anonymous

See bug #21329

(Browse SVN revision 23973)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 30 Dec 2013 05:20:56 AM UTC, comment #3:

The original problem seems not to apply to isophex (isometric hex). Attached versions of the patch drops the changes to isohex handling. Also fixed unit movement animation offsets.

(file #19568, file #19569)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 30 Dec 2013 04:44:43 AM UTC, comment #2:

- Updated hex2t items.png

(file #19567)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 06 Dec 2013 11:11:10 PM UTC, comment #1:

Problem is that "full tile height" is rather high for hex tiles (iso or not), meaning origin is far above the "normal tile height" origin.

Part of the code calculating full tile height considers all hex tiles to be like iso squares, and has:
t->full_tile_height = 3 * t->normal_tile_height / 2;

Attached WIP patch makes full tile height for hex tiles same as normal tile height. This version does not touch isophex yet, but somewhat adjusted version of hex2t is included. Even hex2t is not finished though, as some sprites (tile output at least), despite being part of full tile size grid, use different origin and are now then moved to wrong position.

For the hex2t change in origin is:
old full tile height - new full tile height =
3 * normal tile height / 2 - normal tile height =
1/2 * normal tile height = 1/2 * 72 = 36 pixels.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 05 Dec 2013 03:28:53 AM UTC, original submission:

I noticed this while working on a new tileset for the non-iso (i.e. vertical sides) hex topography.

There is a large amount of whitespace above unit graphics in the city overview window, specifically the panels showing supported and present units. Besides just looking a bit sloppy, it means that less screen space is available for things like the city map and improvements list. This is especially relevant for users with low screen resolutions.

It doesn't seem to be affected by offsets in the tilespec file. And the whitespace isn't present in amplio2, which has an iso rectangular topography.

Following are some of the relevant tilespec values for the images provided. Keep in mind that the offset values are all necessary to keep the units aligned with the grid, and that the HP bars can't be moved by offsets. I think it's also worth noting that the y offsets for the two hex tilesets are much larger than those needed in amplio2. In my own set, the pink hexes are guides I used to help me line up the unit graphics with the grid.

My set:
normal_tile_width = 128
normal_tile_height = 126
unit_flag_offset_x = 0
unit_flag_offset_y = 63
unit_offset_x = 0
unit_offset_y = 63

Hex2t:
normal_tile_width = 40
normal_tile_height = 72
unit_flag_offset_x = 1
unit_flag_offset_y = 59
unit_offset_x = 4
unit_offset_y = 57

Amplio2:
normal_tile_width = 96
normal_tile_height = 48
unit_flag_offset_x = 25
unit_flag_offset_y = 16
unit_offset_x = 19
unit_offset_y = 18

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19569:  HexFullTileHeight-2.patch added by cazfi (2kB - text/x-diff)
file #19567:  items.png added by cazfi (44kB - image/png)
file #19424:  HexFullTileHeight.patch added by cazfi (2kB - text/x-diff)
file #19425:  items.png added by cazfi (43kB - image/png)
file #19419:  bug-freeciv-whitespace.png added by None (82kB - image/png)
file #19420:  bug-freeciv-whitespace3.png added by None (95kB - image/png)
file #19421:  bug-freeciv-whitespace2.png added by None (92kB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 14 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 01 Jan 2014 11:17:22 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 30 Dec 2013 05:20:56 AM UTCcazfiAttached File-=>Added HexFullTileHeight-S2_5-2.patch, #19568
      Attached File-=>Added HexFullTileHeight-2.patch, #19569
      StatusNone=>Ready For Test
      Planned Release=>2.5.0, 2.6.0
    Mon 30 Dec 2013 04:44:43 AM UTCcazfiAttached File-=>Added items.png, #19567
    Fri 06 Dec 2013 11:12:20 PM UTCcazfiCategoryart=>client
    Fri 06 Dec 2013 11:11:45 PM UTCcazfiAttached File-=>Added HexFullTileHeight.patch, #19424
      Attached File-=>Added items.png, #19425
    Thu 05 Dec 2013 03:28:53 AM UTCNoneAttached File-=>Added bug-freeciv-whitespace.png, #19419
      Attached File-=>Added bug-freeciv-whitespace3.png, #19420
      Attached File-=>Added bug-freeciv-whitespace2.png, #19421
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup