bugFreeciv - Bugs: bug #21348, ...

 
 
Show feedback again

bug #21348: server/edithand.c:handle_scenario_info() looks redundant

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 14 Dec 2013 03:48:30 PM UTC  
 
Category: generalSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 11 Mar 2014 10:05:33 PM UTC, SVN revision 24653:

Add concept of nation mood.

Updated network protocol to the fact that PACKET_SCENARIO_INFO never
needs to be sent from client to the server.

Reported by Jacob Nevins

See bug #21348

(Browse SVN revision 24653)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 11 Mar 2014 09:48:05 PM UTC, SVN revision 24652:

Updated network protocol to the fact that PACKET_SCENARIO_INFO never
needs to be sent from client to the server.

Reported by Jacob Nevins

See bug #21348

(Browse SVN revision 24652)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 11 Mar 2014 09:47:59 PM UTC, SVN revision 24651:

Updated network protocol to the fact that PACKET_SCENARIO_INFO never
needs to be sent from client to the server.

Reported by Jacob Nevins

See bug #21348

(Browse SVN revision 24651)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 08 Mar 2014 11:54:08 PM UTC, comment #1:

Patch

(file #20289)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 14 Dec 2013 03:48:30 PM UTC, original submission:

PACKET_SCENARIO_INFO is defined as a packet that can go both server->client and client->server, but never actually goes in the c->s direction in practice. Client edits to this information go in PACKET_EDIT_GAME instead.

It's been this way since r15698, RT #40229. I'm guessing that this was the original plan for the editor before PACKET_EDIT_GAME was added (r15701, bug #13452) so now is vestigial.

Bug #13452 does say this:

> I'm not sure if the duplicated work in handle_scenario
> _info() and handle_edit_game() is ideal. Sure if there
> were a specialized gui widget for setting scenario
> parameters it would have to use the scenario info
> packet, but I think the property editor is enough

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20289:  OneWayScenarioInfo.patch added by cazfi (1kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 11 Mar 2014 09:48:20 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat 08 Mar 2014 11:54:08 PM UTCcazfiAttached File-=>Added OneWayScenarioInfo.patch, #20289
      CategoryNone=>general
      StatusNone=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup