bugFreeciv - Bugs: bug #21350, Supplied scenario start positions...

 
 
Show feedback again

bug #21350: Supplied scenario start positions vs core nations

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 15 Dec 2013 11:25:19 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: Any
Planned Release: 2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 06 Jul 2014 09:38:56 AM UTC, comment #3:

> When the core nation set is rigidly enforced [...] our supplied
> scenarios which specify nation-specific start positions will
> cause trouble

Oh, past-me, why so vague?

I'm guessing that by "trouble" I meant "looks a bit ugly", in that the game may have to choose nations which aren't in the scenario, and then match them to start positions that were designed for someone else; and that there's no user indication of this until the game starts.

A mitigating factor is the default aifill in the scenario. If that's set so that there are sufficient 'core' nations to cover, you'll only see the ugliness if you change it or have very many human players. Otherwise those start positions which are for non-core nations will never be used with nationset=core, I think.

Anyway, I came back here to note that bardo tweaked one of the Earth scenarios under patch #4842 in a way which should improve this.

Survey of the scenarios previously marked as "troublesome":

  • british-isles-85x80-v2.80.sav: 1/5 in core; aifill not set, default 5 ugly
  • earth-160x90-v2.sav: new 30/38 in core; aifill 30
  • earth-80x50-v3.sav: 16/18 core; aifill 10
  • europe-200x100-v2.sav: 16/37 core; aifill 14
  • france-140x90-v2.sav: 15/27 core; aifill 18 ugly
  • north_america_116x100-v1.2.sav: 10/12 core; aifill 12 ugly
Jacob Nevins <jtn>
Project Administrator
Sat 21 Dec 2013 05:36:50 PM UTC, comment #2:

> (I'm also still working out what patch #3448 will do if it
> encounters a start position unusable in the current nationset --
> probably it will disable it and reduce the max players
> accordingly.)

As submitted, it doesn't try to reduce the number of players (similar to if the scenario defines startpos_nations).

It's possible to end up with no pickable nations, if start positions and naionset don't overlap -- but because the server will fall back to other nations in this case on game start, this is not actually treated as an error.

Jacob Nevins <jtn>
Project Administrator
Sun 15 Dec 2013 11:28:17 AM UTC, comment #1:

(I'm also still working out what patch #3448 will do if it encounters a start position unusable in the current nationset -- probably it will disable it and reduce the max players accordingly.)

Jacob Nevins <jtn>
Project Administrator
Sun 15 Dec 2013 11:25:19 AM UTC, original submission:

When the core nation set is rigidly enforced by default (patch #3448), our supplied scenarios which specify nation-specific start positions will cause trouble, due to some start positions only being usable by nations outside the core set. Details of individual scenarios below.

I haven't worked out quite what the right thing to do is yet, but some disorganised thoughts:

  • Could just specify a non-default nationset in the scenario, but the point of nation sets was to avoid people bumping into possibly-untranslated strings without choosing to, so having supplied scenarios reliant on them might not be ideal.
    • (Could also try to auto-fit nationset to start positions if none specified, similar to what patch #3448 is doing for players in old savefiles.)
  • Some scenarios are for small geographic regions (e.g., british-isles), so will inevitably want nations outside the core set.
  • We could specify that multiple nations can start at a given position, including core and more specific non-core nations -- the scenario format permits this -- but I'm reluctant to use this facility due to current poor UI -- players aren't given any indication that a given nation is a poor choice because its only start position has been ruled out by another player's choice of nation. Could add network signalling for this (possibly triggered by the same scenario option as bug #21268).
    • Possibly it would be useful for a scenario to be able to specify preferred nations for start positions, so that if a more specific nation is available it's picked over the core one? Not at all sure about this.

Survey of scenarios on trunk:

  • Troublesome scenarios
    • british-isles-85x80-v2.80.sav: 1/5 in core
      • Not core: Irish, Welsh, Cornish, Scottish
    • earth-160x90-v2.sav: 24/30 core
      • Not core: Gallic, Inuit, Manchu, Cambodian, Papuan, British
    • earth-80x50-v3.sav: 16/18 core
      • Not core: Australian Aboriginal, Inuit
    • europe-200x100-v2.sav: 16/37 core
      • Not core: Bavarian, Belgian, Bosnian-Herzegovinian, Bulgarian, Croatian, Czech, Estonian, Finnish, Hungarian, Icelandic, Irish, Israeli, Latvian, Lithuanian, Romanian, Scottish, Serbian, Slovakian, Slovenian, Swiss, Ukrainian
    • france-140x90-v2.sav: 15/27 core
      • Not core: Bavarian, Belgian, Catalan, Cornish, Finnish, Galician, Icelandic, Phoenician, Quebecois, Scottish, Swiss, Welsh
    • north_america_116x100-v1.2.sav: 10/12 core
      • Not core: Scottish, Irish
  • OK scenarios
    • japan-88x100-v1.3.sav: 8/8 core
    • hagworld-120x60-v1.2.sav: no start positions
    • iberian-peninsula-136x100-v1.0.sav: no nation-specific start positions
    • italy-100x100-v1.5.sav: no start positions
Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup