bugFreeciv - Bugs: bug #21374, in concat_tile_activity_text()...

 
 
Show feedback again

bug #21374: in concat_tile_activity_text() [text.c::487]: assertion 'cause != EC_NONE' failed.

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Wed Dec 25 22:14:38 2013  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: trunk r23897Operating System: GNU/Linux
Planned Release: 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed Jan 1 23:08:52 2014, comment #5:

> Mining would benefit from similar change, but left to another
> ticket for potential controversy.


patch #4382

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Jan 1 23:03:11 2014, SVN revision 23972:

Reworked concat_tile_activity_text() to work with extra removal actions that take target.

Reported by Jacob Nevins

See bug #21374

(Browse SVN revision 23972)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Dec 30 01:33:12 2013, comment #3:

Changes plans so that there will not be major rewrite (in separate ticket) for handling irrigation/mine terrain changes, so take care of handling that case in concat_tile_activity_text() in this ticket.
Also changed name of the Irrigation activity to be "Irrigate" so it can be distinguished from building extra "Irrigation". Mining would benefit from similar change, but left to another ticket for potential controversy. (Could we go so far from the "Mine" as "Plant" as in most (all?) rulesets terrain changes made as "Mining" are related to plants?)

(file #19564)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Dec 26 02:07:30 2013, comment #2:

Patch suitable for this ticket.

There's an issue that Irrigate and Mine activities always have target extra - if not requested by the client, then automatically assigned default value. That's not correct when those activities are used to change the terrain type, and this tile popup gives wrong number of turns in that case (time to build that default extra instead of terrain change time)

(file #19519)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Dec 26 00:02:39 2013, comment #1:

Right, I had forgotten how that part of code would break when cleaning activities get targets. I'm working on feature patch on top of which proper fix for this can be made.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Dec 25 22:14:38 2013, original submission:

As subject, appearing whenever I middle-click on a tile in the Gtk2 client to get an information popup.

I'm guessing this is caused by ACTIVITY_POLLUTION/FALLOUT returning TRUE from activity_requires_target() but not then being handled in the switch statement where the assertio fails.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19564:  ActRmActTimes-2.patch added by cazfi (8kB - text/x-diff)
file #19519:  ActRmActTimes.patch added by cazfi (8kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed Jan 1 23:09:13 2014cazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon Dec 30 01:33:12 2013cazfiAttached File-=>Added ActRmActTimes-2.patch, #19564
    Thu Dec 26 02:07:30 2013cazfiAttached File-=>Added ActRmActTimes.patch, #19519
      StatusNone=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup