bugFreeciv - Bugs: bug #21382, Apparent off-by-one in road and...

Show feedback again

bug #21382: Apparent off-by-one in road and base editor tools

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat Dec 28 12:26:12 2013  
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: trunk r23905Operating System: GNU/Linux
Planned Release: 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Thu Jan 9 16:47:08 2014, SVN revision 24080:

Fixed setting of base and road type ids on client side.

Reported by Jacob Nevins

See bug #21382

(Browse SVN revision 24080)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Jan 5 06:17:39 2014, comment #1:

It's base/road id's being one off in client side.

Fix attached

(file #19677)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Dec 28 12:26:12 2013, original submission:

On current trunk (both Gtk2 and Gtk3 clients), if I select a type of road or base from the editor tool popup, the next one is selected (e.g., classic ruleset, if I choose Road, I get Railroad). The first road/base type is inaccessible; selecting the last type causes errors about an invalid base/road ID if I try to use it.

S2_5 is not affected.

Jacob Nevins <jtn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #19677:  BaseRoadEditOffByOne.patch added by cazfi (1003B - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by jtn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Jan 9 16:47:31 2014cazfiStatusReady For Test=>Fixed
    Sun Jan 5 06:17:39 2014cazfiAttached File-=>Added BaseRoadEditOffByOne.patch, #19677
      StatusNone=>Ready For Test
      Assigned toNone=>cazfi
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup