bugFreeciv - Bugs: bug #21382, Apparent off-by-one in road and...

 
 
Show feedback again

bug #21382: Apparent off-by-one in road and base editor tools

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 28 Dec 2013 12:26:12 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: trunk r23905Operating System: GNU/Linux
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 09 Jan 2014 04:47:08 PM UTC, SVN revision 24080:

Fixed setting of base and road type ids on client side.

Reported by Jacob Nevins

See bug #21382

(Browse SVN revision 24080)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 05 Jan 2014 06:17:39 AM UTC, comment #1:

It's base/road id's being one off in client side.

Fix attached

(file #19677)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 28 Dec 2013 12:26:12 PM UTC, original submission:

On current trunk (both Gtk2 and Gtk3 clients), if I select a type of road or base from the editor tool popup, the next one is selected (e.g., classic ruleset, if I choose Road, I get Railroad). The first road/base type is inaccessible; selecting the last type causes errors about an invalid base/road ID if I try to use it.

S2_5 is not affected.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19677:  BaseRoadEditOffByOne.patch added by cazfi (1003B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 09 Jan 2014 04:47:31 PM UTCcazfiStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 05 Jan 2014 06:17:39 AM UTCcazfiAttached File-=>Added BaseRoadEditOffByOne.patch, #19677
      Categoryclient-gtk-2.0=>client
      StatusNone=>Ready For Test
      Assigned toNone=>cazfi
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup