bugFreeciv - Bugs: bug #21420, Worklist postponement messages...

 
 
Show feedback again

bug #21420: Worklist postponement messages don't consistently support negated requirements

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Fri 03 Jan 2014 03:42:58 AM UTC  
 
Category: generalSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Emmet Hikory <persia>Open/Closed: Closed
Release: trunk r23973Operating System: None
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 19 Jun 2014 03:54:38 PM UTC, SVN revision 25205:

Worklist explanation improvements

  • Explain why units can't be built (government, improvement, tech)
  • Consider negated requirements when explaining improvement postponement
  • Rework improvement purging logic: purge in more unachievable cases
  • Change double-spacing in messages to single-spacing

See bug #21420

(Browse SVN revision 25205)

Emmet Hikory <persia>
Project MemberIn charge of this item.
Tue 17 Jun 2014 09:17:01 PM UTC, comment #5:

Sorry to have forgotten this for a while. Updated, and issues addressed.

(file #21072)

Emmet Hikory <persia>
Project MemberIn charge of this item.
Fri 09 May 2014 07:15:59 AM UTC, comment #4:

I guess this should be the the same after '!' in "reason unknown! Postponing..."

pepeto <pepeto>
Project Member
Fri 09 May 2014 05:56:53 AM UTC, comment #3:

Good catch. Updated patch with string spacing reduction attached (this is an improvement to CodingStyle over the current strings).

(file #20694)

Emmet Hikory <persia>
Project MemberIn charge of this item.
Thu 08 May 2014 07:39:40 PM UTC, comment #2:

Just had a look to your patch... I didn't see anything wrong except that strings containing multiple sentences should be separated by one space only, according to coding style.

pepeto <pepeto>
Project Member
Sun 04 May 2014 04:04:02 AM UTC, comment #1:

In addition to the improvement messages failing to handle present==FALSE requirements, the unit messages fail to consider anything other than missing technologies. Merging these issues for simplicity of patch management.

Emmet Hikory <persia>
Project MemberIn charge of this item.
Fri 03 Jan 2014 03:42:58 AM UTC, original submission:

worklist_change_build_target() attempts to diagnose why it can't build an improvement from the worklist ("Kuala Lumpur can't build Airport from the worklist; tech Radio not yet available! Postponing...")

However, only for one requirement (VUT_MAXTILEUNITS) does it check preq->present; for others, it might give misleading answers in the face of negated (present==FALSE) requirements.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20631:  worklist-explanation-improvements.patch added by persia (51kB - application/octet-stream)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by persia (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 19 Jun 2014 04:35:54 PM UTCpersiaStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 17 Jun 2014 09:17:01 PM UTCpersiaAttached File-=>Added worklist-explanation-improvements+less-spaces.patch, #21072
    Fri 09 May 2014 05:56:53 AM UTCpersiaAttached File-=>Added worklist-explanation-improvements+spacing.patch, #20694
    Sun 04 May 2014 08:34:37 AM UTCpersiaAttached File-=>Added worklist-explanation-improvements.patch, #20631
      StatusIn Progress=>Ready For Test
    Sun 04 May 2014 04:04:02 AM UTCpersiaCategoryNone=>general
      StatusNone=>In Progress
      Assigned toNone=>persia
      Planned Release=>2.6.0
    Mon 21 Apr 2014 12:00:57 PM UTCjtnSeverity3 - Normal=>2 - Minor
    Fri 03 Jan 2014 05:26:10 AM UTCjtnDependencies-=>bugs #21115 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup