bugFreeciv - Bugs: bug #21420, Worklist postponement messages...

Show feedback again

bug #21420: Worklist postponement messages don't consistently support negated requirements

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Fri Jan 3 03:42:58 2014  
Category: generalSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Emmet Hikory <persia>Open/Closed: Closed
Release: trunk r23973Operating System: None
Planned Release: 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


(Jump to the original submission Jump to the original submission)

Thu Jun 19 15:54:38 2014, SVN revision 25205:

Worklist explanation improvements

  • Explain why units can't be built (government, improvement, tech)
  • Consider negated requirements when explaining improvement postponement
  • Rework improvement purging logic: purge in more unachievable cases
  • Change double-spacing in messages to single-spacing

See bug #21420

(Browse SVN revision 25205)

Emmet Hikory <persia>
Project MemberIn charge of this item.
Tue Jun 17 21:17:01 2014, comment #5:

Sorry to have forgotten this for a while. Updated, and issues addressed.

(file #21072)

Emmet Hikory <persia>
Project MemberIn charge of this item.
Fri May 9 07:15:59 2014, comment #4:

I guess this should be the the same after '!' in "reason unknown! Postponing..."

pepeto <pepeto>
Project Member
Fri May 9 05:56:53 2014, comment #3:

Good catch. Updated patch with string spacing reduction attached (this is an improvement to CodingStyle over the current strings).

(file #20694)

Emmet Hikory <persia>
Project MemberIn charge of this item.
Thu May 8 19:39:40 2014, comment #2:

Just had a look to your patch... I didn't see anything wrong except that strings containing multiple sentences should be separated by one space only, according to coding style.

pepeto <pepeto>
Project Member
Sun May 4 04:04:02 2014, comment #1:

In addition to the improvement messages failing to handle present==FALSE requirements, the unit messages fail to consider anything other than missing technologies. Merging these issues for simplicity of patch management.

Emmet Hikory <persia>
Project MemberIn charge of this item.
Fri Jan 3 03:42:58 2014, original submission:

worklist_change_build_target() attempts to diagnose why it can't build an improvement from the worklist ("Kuala Lumpur can't build Airport from the worklist; tech Radio not yet available! Postponing...")

However, only for one requirement (VUT_MAXTILEUNITS) does it check preq->present; for others, it might give misleading answers in the face of negated (present==FALSE) requirements.

Jacob Nevins <jtn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #20631:  worklist-explanation-improvements.patch added by persia (51kB - application/octet-stream)


Depends on the following items: None found

   bug dependencies.


Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by persia (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Jun 19 16:35:54 2014persiaStatusReady For Test=>Fixed
    Tue Jun 17 21:17:01 2014persiaAttached File-=>Added worklist-explanation-improvements+less-spaces.patch, #21072
    Fri May 9 05:56:53 2014persiaAttached File-=>Added worklist-explanation-improvements+spacing.patch, #20694
    Sun May 4 08:34:37 2014persiaAttached File-=>Added worklist-explanation-improvements.patch, #20631
      StatusIn Progress=>Ready For Test
    Sun May 4 04:04:02 2014persiaCategoryNone=>general
      StatusNone=>In Progress
      Assigned toNone=>persia
      Planned Release=>2.6.0
    Mon Apr 21 12:00:57 2014jtnSeverity3 - Normal=>2 - Minor
    Fri Jan 3 05:26:10 2014jtnDependencies-=>bugs #21115 is dependent
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup