bugFreeciv - Bugs: bug #21430, Ignore negated requirements in...

 
 
Show feedback again

bug #21430: Ignore negated requirements in client improvement prerequisites help

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Fri 03 Jan 2014 03:20:53 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.4.2,2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 05 Jan 2014 10:59:22 AM UTC, SVN revision 24051:

Ignore negated requirements in client-specific display of improvement
prerequisites to avoid misleading help.

See gna bug #21430.

(Browse SVN revision 24051)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 05 Jan 2014 10:55:02 AM UTC, SVN revision 24039:

Ignore negated requirements in client-specific display of improvement
prerequisites to avoid misleading help.

See gna bug #21430.

(Browse SVN revision 24039)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 05 Jan 2014 10:47:36 AM UTC, SVN revision 24027:

Ignore negated requirements in client-specific display of improvement
prerequisites to avoid misleading help.

See gna bug #21430.

(Browse SVN revision 24027)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 03 Jan 2014 03:46:41 PM UTC, comment #2:

(The first patch for bug #21425 -- file #19630 -- addresses this by adding a "!" in front, so "!Construction" would be displayed if no-Construction was the first req -- but I won't be taking that patch forward.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 03 Jan 2014 03:24:36 PM UTC, comment #1:

(This probably doesn't actually bite that often, because generally there will be a non-negated requirement and it will likely be the first one.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 03 Jan 2014 03:20:53 PM UTC, original submission:

The various client-specific code that decides what "the" prerequisite for a building is can erroneously pick a negated requirement and present it as a prerequisite.

There's lots wrong with this area, which can be the subject of another ticket, but in this one I'll tweak the code to just ignore negated requirements.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19651:  trunk-impr-req-negated-help.patch added by jtn (7kB - text/x-diff - trunk/S2_5/S2_4 r24003)
file #19652:  S2_5-impr-req-negated-help.patch added by jtn (6kB - text/x-diff - trunk/S2_5/S2_4 r24003)
file #19653:  S2_4-impr-req-negated-help.patch added by jtn (6kB - text/x-diff - trunk/S2_5/S2_4 r24003)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 05 Jan 2014 11:05:38 AM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 03 Jan 2014 08:08:46 PM UTCjtnAttached File-=>Added trunk-impr-req-negated-help.patch, #19651
      Attached File-=>Added S2_5-impr-req-negated-help.patch, #19652
      Attached File-=>Added S2_4-impr-req-negated-help.patch, #19653
      StatusIn Progress=>Ready For Test
      Planned Release=>2.4.2,2.5.0,2.6.0
    Fri 03 Jan 2014 03:50:32 PM UTCjtnDependencies-=>bugs #21115 is dependent
    Fri 03 Jan 2014 03:25:20 PM UTCjtnDependencies-=>bugs #21431 is dependent
    Fri 03 Jan 2014 03:24:44 PM UTCjtnSummaryIgnore negated requirements in client improvement prerequisites=>Ignore negated requirements in client improvement prerequisites help
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup