bugFreeciv - Bugs: bug #21436, Connect with rail can no longer...

 
 
Show feedback again

bug #21436: Connect with rail can no longer build roads first

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 04 Jan 2014 01:44:38 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: S2_5, trunkOperating System: Any
Planned Release: 2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 17 Mar 2014 09:31:45 PM UTC, SVN revision 24694:

When doing connect activity with some road type, recursively build also
dependency roads.

Requested by Jacob Nevins

See bug #21436

(Browse SVN revision 24694)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 17 Mar 2014 09:31:35 PM UTC, SVN revision 24693:

When doing connect activity with some road type, recursively build also
dependency roads.

Requested by Jacob Nevins

See bug #21436

(Browse SVN revision 24693)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 15 Mar 2014 02:20:29 AM UTC, comment #3:

Patch.

All the recursive requirement extras must be roads - does not use actions other than ACTIVITY_GEN_ROAD to build the requirements.

(file #20337, file #20338)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 05 Jan 2014 03:59:22 AM UTC, comment #2:

> might be hard to solve in general


Note, however, that updates to user interface have been minimal - full potential of gen-roads and extras is not exposed to users. There's no such thing as "connect gen-road" as there's only "connect with ROCO_ROAD" and "connect with ROCO_RAIL".

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 04 Jan 2014 01:49:31 PM UTC, comment #1:

> This is presumably caused by gen-roads, and might be hard to
> solve in general


I assume we will be able to re-use most of the code used to solve similar problem on placing railroads from editor.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 04 Jan 2014 01:44:38 PM UTC, original submission:

On S2_5 and trunk, if I try to direct a worker unit to connect-with-rail (shift-L) in a place where there are no roads, it is prohibited (I get a red-circle-with-line-through cursor).
In 2.4.x the unit built the roads first.
This is presumably caused by gen-roads, and might be hard to solve in general, but it is a bit of an annoying regression, increasing micromanagement.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 17 Mar 2014 09:31:54 PM UTCcazfiStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 15 Mar 2014 02:20:29 AM UTCcazfiAttached File-=>Added RecursiveRoadConnect.patch, #20337
      Attached File-=>Added RecursiveRoadConnect-S2_5.patch, #20338
      StatusIn Progress=>Ready For Test
    Sun 05 Jan 2014 01:46:17 AM UTCcazfiCategoryNone=>client
      StatusNone=>In Progress
      Assigned toNone=>cazfi
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup