bugBattle for Wesnoth - Bugs: bug #21450, Units can be moved in linger mode

 
 
Show feedback again

bug #21450: Units can be moved in linger mode

Submitted by:  B. Lipka <lipk>
Submitted on:  Mon 06 Jan 2014 12:08:54 AM UTC  
 
Category: BugSeverity: 5 - Blocker
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: J Tyne <jamit>Open/Closed: Closed
Release: 1.11.8Operating System: Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 23 Feb 2014 08:43:26 AM UTC, comment #4:

Fixed in 3b69ba802bd6.

Linger mode worked before because previously the mouse handler respect the controller's browse_ setting. Then someone decided to assume browse was always false. Now browse is again set to the controller's setting.

J Tyne <jamit>
Project MemberIn charge of this item.
Sun 02 Feb 2014 04:07:13 PM UTC, comment #3:

Crab added a command_disabler to linger mode. This fixes this bug, but raises the question of why linger mode worked before. He suspects this was a bug itself and that it was accidentally fixed at some point.

Alexander van Gessel <ai0867>
Project Member
Mon 20 Jan 2014 01:36:41 AM UTC, comment #2:

My previous bisect got the wrong commit because incompatible preferences files rendered my attempts to move units ineffective.

The actual commit is 7e46df919167c6906d7a782b8f77104444cdee5a, which is the one in which the new control scheme was introduced.

Alexander van Gessel <ai0867>
Project Member
Sun 19 Jan 2014 01:18:54 PM UTC, comment #1:

Bisect indicates this was broken in 5463068caffb42df8eeb9a044479ef7fc379e622.

Alexander van Gessel <ai0867>
Project Member
Mon 06 Jan 2014 12:08:54 AM UTC, original submission:

...which should not be possible. Furthermore, if you attack another unit (which is also allowed), the game quits to the title screen.

B. Lipka <lipk>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jamit (Posted a comment)
  • -unavailable- added by ai0867 (Fixed the bug)
  • -unavailable- added by ai0867 (Posted a comment)
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by lipk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 06 Mar 2014 11:00:30 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sun 23 Feb 2014 08:43:26 AM UTCjamitStatusConfirmed=>Fixed
      Assigned tofendrin=>jamit
    Sun 02 Feb 2014 04:07:13 PM UTCai0867Carbon-Copy-=>Added -unavailable-
    Mon 20 Jan 2014 02:06:51 AM UTCai0867Assigned toNone=>fendrin
    Mon 06 Jan 2014 12:15:13 AM UTCshadowmasterSeverity3 - Normal=>5 - Blocker
      StatusNone=>Confirmed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup