bugFreeciv - Bugs: bug #21468, Edit start positions sent to...

 
 
Show feedback again

bug #21468: Edit start positions sent to detached connections

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 11 Jan 2014 02:21:28 PM UTC  
 
Category: editorSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: S2_4 r24096Operating System: GNU/Linux
Planned Release: 2.4.3, 2.5.0-beta2, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 25 Jul 2014 07:46:45 AM UTC, SVN revision 25724:

Make detached connection unable to edit. It will prevent them to receive
undesired packets when connecting when the game is in edit mode.

Reported by Jacob Nevins

See gna bug #21468

(Browse SVN revision 25724)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 25 Jul 2014 07:46:39 AM UTC, SVN revision 25723:

Make detached connection unable to edit. It will prevent them to receive
undesired packets when connecting when the game is in edit mode.

Reported by Jacob Nevins

See gna bug #21468

(Browse SVN revision 25723)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 25 Jul 2014 07:46:33 AM UTC, SVN revision 25722:

Make detached connection unable to edit. It will prevent them to receive
undesired packets when connecting when the game is in edit mode.

Reported by Jacob Nevins

See gna bug #21468

(Browse SVN revision 25722)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 23 Jul 2014 04:08:48 PM UTC, comment #1:

Fix attached.

(file #21524)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 11 Jan 2014 02:21:28 PM UTC, original submission:

While debugging bug #21279, I noticed that entering edit mode with a detached client, the latter gives a string of

Root cause is similar to bug #21279 but much less severe: edithand_send_initial_packets() sends stuff to detached connections. This is unlikely to be much of a problem in practice as edit mode will generally only be used in single-player games.

Not sure what the correct fix is. Connection list is currently guarded by can_conn_edit() which is based on ALLOW_* and is true for my detached connection.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21524:  can_conn_edit.patch added by pepeto (643B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 25 Jul 2014 07:47:00 AM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 23 Jul 2014 04:08:48 PM UTCpepetoAttached File-=>Added can_conn_edit.patch, #21524
      CategoryNone=>editor
      StatusNone=>Ready For Test
      Assigned toNone=>pepeto
      Planned Release=>2.4.3, 2.5.0-beta2, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup