bugFreeciv - Bugs: bug #21468, Edit start positions sent to...

 
 
Show feedback again

bug #21468: Edit start positions sent to detached connections

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 11 Jan 2014 02:21:28 PM UTC  
 
Category: NoneSeverity: 2 - Minor
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: S2_4 r24096Operating System: GNU/Linux
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 11 Jan 2014 02:21:28 PM UTC, original submission:

While debugging bug #21279, I noticed that entering edit mode with a detached client, the latter gives a string of

Root cause is similar to bug #21279 but much less severe: edithand_send_initial_packets() sends stuff to detached connections. This is unlikely to be much of a problem in practice as edit mode will generally only be used in single-player games.

Not sure what the correct fix is. Connection list is currently guarded by can_conn_edit() which is based on ALLOW_* and is true for my detached connection.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup