bugBattle for Wesnoth - Bugs: bug #21620, Aggregate [damage] specials'...

Show feedback again

bug #21620: Aggregate [damage] specials' multiply= and divide= with alignment, etc.

Submitted by:  Eli Dupree <elvish_pillager>
Submitted on:  Sat Feb 8 16:51:08 2014  
Category: Feature RequestSeverity: 1 - Wish
Priority: 5 - NormalItem Group: WML
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: 1.11.8+devOperating System: Debian Linux

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat Feb 8 16:51:08 2014, original submission:

Currently, weapon specials' damage modifications are applied separately, before alignment, leadership, and resistances, and they round down (see unit_abilities.cpp:1043). This is especially bad for specials that reduce damage by a large factor.

I believe that multiply= and divide= in attack specials should be aggregated with those other effects and applied in one pass with one rounding.

The worst case scenario: A unit attacks with a 5-damage attack against a special that divides by 3, while getting +50% from leadership.
Current behavior:
5/3 = 1.67, rounds to 1.
1 * 150% = 1.5, rounds to 1 (because it rounds towards the value after specials, not the original value)
Desired behavior:
5/3 * 150% = 2.5, rounds to 3.

Eli Dupree <elvish_pillager>


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by elvish_pillager (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup