bugFreeciv - Bugs: bug #21630, Default AI diplomacy tries to read...

 
 
Show feedback again

bug #21630: Default AI diplomacy tries to read minds

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 10 Feb 2014 07:53:10 PM UTC  
 
Category: aiSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.3, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 16 Mar 2014 08:45:41 PM UTC, SVN revision 24688:

Default AI does not try to check if ally plans to declare war on its behalf.
That was working only when the ally had exactly same AI type, and was not an
human player. Otherwise it worked on incorrect data.

See bug #21630

(Browse SVN revision 24688)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 16 Mar 2014 08:45:36 PM UTC, SVN revision 24687:

Default AI does not try to check if ally plans to declare war on its behalf.
That was working only when the ally had exactly same AI type, and was not an
human player. Otherwise it worked on incorrect data.

See bug #21630

(Browse SVN revision 24687)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 16 Mar 2014 08:45:31 PM UTC, SVN revision 24686:

Default AI does not try to check if ally plans to declare war on its behalf.
That was working only when the ally had exactly same AI type, and was not an
human player. Otherwise it worked on incorrect data.

See bug #21630

(Browse SVN revision 24686)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 02 Mar 2014 01:55:14 AM UTC, comment #1:

Attached patch removes the mind reading part about whether ally is preparing for the war against our enemy. We expect ally to really declare the war before we believe him to do so.
Adjusted the code a bit so we'll give time for ally's war coutdown after we first ask his help now that we are not satisfied as soon as countdown begins.

(file #20228, file #20229)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 10 Feb 2014 07:53:10 PM UTC, original submission:

At least when considering if ally is trustworthy, default ai in its omniscient way checks plans of the ally from its default ai data. I don't think that data is valid, even less accurate, in case of human player, or player with another ai type.

This came up when debugging bug #21616 - it's possible that nonsensical default ai data in human player's storage is the reason of that bug, but I don't yet see how.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20228:  AllyPlans.patch added by cazfi (3kB - text/x-diff)
file #20229:  AllyPlans-S2_4.patch added by cazfi (3kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 16 Mar 2014 08:45:53 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 02 Mar 2014 01:55:14 AM UTCcazfiAttached File-=>Added AllyPlans.patch, #20228
      Attached File-=>Added AllyPlans-S2_4.patch, #20229
      StatusNone=>Ready For Test
      Planned Release=>2.4.3, 2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup