bugFreeciv - Bugs: bug #21631, phasemode not documented as only...

 
 
Show feedback again

bug #21631: phasemode not documented as only taking effect next turn

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 10 Feb 2014 09:21:42 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.3, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 09 Aug 2014 12:57:33 PM UTC, comment #7:

> There's no way to see what the phasemode for the current turn is.
> Setting value only shows the storage variable (active next turn)

Since a commit under this ticket is going into 2.4.3, split remaining work to new bug #22454 and repurposing/closing this one.

Jacob Nevins <jtn>
Project Administrator
Mon 17 Feb 2014 02:39:08 AM UTC, comment #6:

Reopening. Forgot this:

> There's no way to see what the phasemode for the current turn is.
> Setting value only shows the storage variable (active next turn)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 17 Feb 2014 02:37:49 AM UTC, SVN revision 24488:

Added notice that setting takes effect next turn to phasemode help.

See bug #21631

(Browse SVN revision 24488)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 17 Feb 2014 02:37:44 AM UTC, SVN revision 24487:

Added notice that setting takes effect next turn to phasemode help.

See bug #21631

(Browse SVN revision 24487)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 17 Feb 2014 02:37:08 AM UTC, SVN revision 24486:

Added notice that setting takes effect next turn to phasemode help.

See bug #21631

(Browse SVN revision 24486)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 10 Feb 2014 10:22:57 PM UTC, comment #2:

> Helptext does not mention that change takes effect only in next turn


Patch for that easy part.

(file #20006)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 10 Feb 2014 10:02:41 PM UTC, comment #1:

Ok, turns out that the setting only changes storage variable. The actual behavior does not change during the turn, but in the beginning of the next turn the storage variable will be copied to actual use.
The problems with this are:
- Helptext does not mention that change takes effect only in next turn
- There's no way to see what the phasemode for the current turn is. Setting value only shows the storage variable (active next turn)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 10 Feb 2014 09:21:42 PM UTC, original submission:

Not tested the actual problems, but it cannot be right that there's no callbacks to handle phasemode changes in a running game - when current phase might be even illegal one in new phasemode, or some players having no phase at all on the entire turn (playing first phase in alternative movement mode so that first player can make his/her moves, then switching to concurrent movement when phase is no longer the first, where all players could move)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20006:  PhasemodeNextTurn.patch added by cazfi (721B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 14 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 09 Aug 2014 12:57:33 PM UTCjtnStatusNone=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
      SummaryChanging phasemode in a running game=>phasemode not documented as only taking effect next turn
    Mon 17 Feb 2014 02:39:32 AM UTCcazfiAssigned tocazfi=>None
    Mon 17 Feb 2014 02:39:08 AM UTCcazfiStatusFixed=>None
      Open/ClosedClosed=>Open
    Mon 17 Feb 2014 02:37:20 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 10 Feb 2014 10:22:57 PM UTCcazfiAttached File-=>Added PhasemodeNextTurn.patch, #20006
      CategoryNone=>general
      StatusNone=>Ready For Test
      Planned Release=>2.4.3, 2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup