bugFreeciv - Bugs: bug #21702, Server built without bzip2 fails...

 
 
Show feedback again

bug #21702: Server built without bzip2 fails to load .bz2 savegame without explaining why

Submitted by:  Christian Knoke <chrisk>
Submitted on:  Fri 21 Feb 2014 02:39:53 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: 2.4.2+Operating System: GNU/Linux
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 15 Jul 2014 08:30:28 PM UTC, comment #9:

See also bug #22283 about general poor file open error reporting.

Jacob Nevins <jtn>
Project Administrator
Sun 23 Feb 2014 03:12:33 PM UTC, comment #8:

> 1) An informataion line in the ./configure summary about which
> compressions are to built in and which not (but could).


Just a note: In S2_5 and TRUNK you have configure option --with-missinglist that tells this, but not enabled by default.

Marko Lindqvist <cazfi>
Project Administrator
Sun 23 Feb 2014 10:38:33 AM UTC, comment #7:

Two things were helpful:

1) An informataion line in the ./configure summary about which compressions are to built in and which not (but could).

2) an error message for the load command, "The savegame could not be loaded, because this freeciv-server programm does not support the type of compression of your file. According to the ending of the name of the file, "bz2", this is bzip2 compression. You can rebuild your Freeciv program to support this, or you decompress your savegame manually, e.g by 'bunzip2 savegame.sav.bz' on the console."

There might be other error reasons, when you copy savegames.

Christian Knoke <chrisk>
Project Member
Sat 22 Feb 2014 12:10:56 PM UTC, comment #6:

It wouldn't seem too evil for Freeciv to hardcode recognition of the start-of-file magic signature for gz/bz2/xz (e.g. 'BZ' for bzip2) for the purpose of fixing this issue.

Jacob Nevins <jtn>
Project Administrator
Sat 22 Feb 2014 11:48:37 AM UTC, comment #5:

Same with any compression method.

Some kind of generic error message can be added, but one cannot tell that bzip2 compression is needed unless one already has it, and can thus identify the savegame as bzip2 compressed one.

Marko Lindqvist <cazfi>
Project Administrator
Fri 21 Feb 2014 11:54:50 PM UTC, comment #4:

fz_from_file in ioz.c:165 fails silently to open savegame.sav.bz2.

checking for gzip... /bin/gzip
checking for BZ2_bzReadOpen in -lbz2... no
checking for lzma_code in -llzma... no

$ bunzip2 bigger-T0142-Y00840-manual.sav.bz2
$ gzip bigger-T0142-Y00840-manual.sav

or installing of libbz2-dev helps out.

Christian

Christian Knoke <chrisk>
Project Member
Fri 21 Feb 2014 09:27:32 PM UTC, comment #3:

> > 1. i386 3.2.0-0.bpo.4-686-pae
> > 2. amd64 2.6.32-5-xen-amd64


> Which of these failed to load the savegame?


the second

> FWIW, I seem to be able to load the savegame fine into S2_4 r24530 (on x86_64 3.2.0-59-generic).


$ md5sum bigger-T0142-Y00840-manual.sav.bz2
5ecc217581c908a810419f34d007398f bigger-T0142-Y00840-manual.sav.bz2

Options?

./autogen.sh --with-efence --enable-debug=yes --enable-svnrev --with-readline --enable-fcdb=all --enable-ipv6=no --enable-client=no --with-fcmp=no --enable-mapimg=no

Christian Knoke <chrisk>
Project Member
Fri 21 Feb 2014 08:52:19 PM UTC, comment #2:

> 1. i386 3.2.0-0.bpo.4-686-pae
> 2. amd64 2.6.32-5-xen-amd64

Which of these failed to load the savegame?

FWIW, I seem to be able to load the savegame fine into S2_4 r24530 (on x86_64 3.2.0-59-generic).

Jacob Nevins <jtn>
Project Administrator
Fri 21 Feb 2014 05:35:50 PM UTC, comment #1:

Other files are transferable and load. file #20133 does not.
files checked. 1 difference 1 line in the log

in savegame2_load() [savegame2.c::559]: loading savefile in new format ...

when the file loads, missing when not.

Christian

Christian Knoke <chrisk>
Project Member
Fri 21 Feb 2014 02:39:53 PM UTC, original submission:

A savegame running on one machine doesn't load in freeciv-server on another machine. Console:
Could not load savefile: bigger-T0142-Y00840-manual.sav.bz2

1. i386 3.2.0-0.bpo.4-686-pae
freeciv-server -v
Encodings: Data=UTF-8, Local=UTF-8, Internal=UTF-8
Freeciv Version 2.4.2+ (r24527)

2. amd64 2.6.32-5-xen-amd64
freeciv@vs:~/freeciv/play$ freeciv-server -v
Encodings: Data=UTF-8, Local=UTF-8, Internal=UTF-8
Freeciv Version 2.4.2+ (r24530)

From level 3 logs (attached) it is unclear to me why. Software is installed with make install on both. Debian oldstable + NLS

Christian

Christian Knoke <chrisk>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20131:  serverlog-gameloaded added by chrisk (16kB - application/octet-stream)
file #20132:  serverlog-notloaded added by chrisk (7kB - application/octet-stream)
file #20133:  bigger-T0142-Y00840-manual.sav.bz2 added by chrisk (104kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by chrisk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Feb 2014 11:14:19 AM UTCjtnSummaryServer can\'t load savegame and doesn\'t tell why=>Server built without bzip2 fails to load .bz2 savegame without explaining why
    Fri 21 Feb 2014 05:36:58 PM UTCchriskRelease=>2.4.2+
    Fri 21 Feb 2014 02:39:53 PM UTCchriskAttached File-=>Added serverlog-gameloaded, #20131
      Attached File-=>Added serverlog-notloaded, #20132
      Attached File-=>Added bigger-T0142-Y00840-manual.sav.bz2, #20133
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup