bugrelax - Bugs: bug #21716, A RelaxError occurs when trying to...

 
 
Show feedback again

bug #21716: A RelaxError occurs when trying to save the state just after deleting the current data pipe.

Submitted by:  Edward d Auvergne <bugman>
Submitted on:  Sun 23 Feb 2014 09:19:15 PM UTC  
 
Category: relax's source codeSpecific analysis category: None
Priority: 3 - LowSeverity: 2 - Minor
Status: FixedAssigned to: Edward d Auvergne <bugman>
Originator Name: Open/Closed: Closed
Release: 3.1.5Operating System: All systems

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 24 Feb 2014 09:00:58 AM UTC, SVN revision 22261:

Merged revisions 22260 via svnmerge from
svn+ssh://bugman@svn.gna.org/svn/relax/trunk

........
r22260 | bugman | 2014-02-24 09:56:30 +0100 (Mon, 24 Feb 2014) | 12 lines

Fix for bug #21716 (https://gna.org/bugs/?21716).

This is the failure to save the relax state just after deleting the current data pipe, even if other
data pipes exist.

The problem was that the specific analysis functions data_names() and return_data_desc() were being
retrieved using the current data pipe rather than the actual data pipe that the data structures
belong to. So if the current data pipe is None, then these fail. Now the data pipe type is being
passed through all of the to_xml() methods so that the correct data_names() and return_data_desc()
methods are retrieved.
........

(Browse SVN revision 22261)

Edward d Auvergne <bugman>
Project AdministratorIn charge of this item.
Mon 24 Feb 2014 08:56:30 AM UTC, SVN revision 22260:

Fix for bug #21716 (https://gna.org/bugs/?21716).

This is the failure to save the relax state just after deleting the current data pipe, even if other
data pipes exist.

The problem was that the specific analysis functions data_names() and return_data_desc() were being
retrieved using the current data pipe rather than the actual data pipe that the data structures
belong to. So if the current data pipe is None, then these fail. Now the data pipe type is being
passed through all of the to_xml() methods so that the correct data_names() and return_data_desc()
methods are retrieved.

(Browse SVN revision 22260)

Edward d Auvergne <bugman>
Project AdministratorIn charge of this item.
Mon 24 Feb 2014 07:57:51 AM UTC, SVN revision 22255:

Merged revisions 22252,22254 via svnmerge from
svn+ssh://bugman@svn.gna.org/svn/relax/trunk

........
r22252 | bugman | 2014-02-23 22:24:51 +0100 (Sun, 23 Feb 2014) | 6 lines

Created the State.test_bug_21716_no_cdp_state_save system test.

This is for catching bug #21716 (https://gna.org/bugs/?21716), the failure to save the relax state
just after deleting the current data pipe, even if other data pipes exist.
........
r22254 | bugman | 2014-02-23 22:25:53 +0100 (Sun, 23 Feb 2014) | 3 lines

Docstring fix for the previous commit (r22252).
........

(Browse SVN revision 22255)

Edward d Auvergne <bugman>
Project AdministratorIn charge of this item.
Sun 23 Feb 2014 09:32:59 PM UTC, comment #2:

To see the failure, open the attached save state in the GUI. Then click on 'Execute'.

(file #20163)

Edward d Auvergne <bugman>
Project AdministratorIn charge of this item.
Sun 23 Feb 2014 09:24:52 PM UTC, SVN revision 22252:

Created the State.test_bug_21716_no_cdp_state_save system test.

This is for catching bug #21716 (https://gna.org/bugs/?21716), the failure to save the relax state
just after deleting the current data pipe, even if other data pipes exist.

(Browse SVN revision 22252)

Edward d Auvergne <bugman>
Project AdministratorIn charge of this item.
Sun 23 Feb 2014 09:19:15 PM UTC, original submission:

The following relax script demonstrates the problem:

=====
pipe.create('a', 'mf')
pipe.create('b', 'mf')
pipe.delete('b')
state.save('x')
=====

This executes as:

=====
relax> pipe.create(pipe_name='a', pipe_type='mf', bundle=None)

relax> pipe.create(pipe_name='b', pipe_type='mf', bundle=None)

relax> pipe.delete(pipe_name='b')

relax> state.save(state='x', dir=None, compress_type=1, force=False)
Opening the file 'x.bz2' for writing.
RelaxError: No data pipes currently exist. Please use the pipe.create user function first.
=====

Although the current pipe is unset, there is still information in the relax data store which should be saved - the entire of the 'a' data pipe!

Edward d Auvergne <bugman>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20163:  bug_21715.bz2 added by bugman (7kB - application/x-bzip2 - relax state file demonstrating the failure.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bugman (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 24 Feb 2014 08:56:47 AM UTCbugmanStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 23 Feb 2014 09:32:59 PM UTCbugmanAttached File-=>Added bug_21715.bz2, #20163
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup