bugFreeciv - Bugs: bug #21725, Loading old savegames with Mines...

 
 
Show feedback again

bug #21725: Loading old savegames with Mines instead of Oil Wells

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 26 Feb 2014 06:26:32 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.6.0, 3.0.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Sep 2015 06:06:57 AM UTC, SVN revision 29927:

When loading specials from pre-2.6 savegame, convert them to extras of equivalent cause
instead of relying on the name of the old special and new extra be the same.

See bug #21725

(Browse SVN revision 29927)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 19 Sep 2015 06:06:47 AM UTC, SVN revision 29926:

When loading specials from pre-2.6 savegame, convert them to extras of equivalent cause
instead of relying on the name of the old special and new extra be the same.

See bug #21725

(Browse SVN revision 29926)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 13 Sep 2015 11:40:24 PM UTC, comment #3:

- Use virtual tile that has the extras we're working on rather than those from the real tile
- Handle savegame.c too

(file #25141, file #25142)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 09 Sep 2015 05:51:55 PM UTC, comment #2:

1) The bug exist
2) With the patch issue is gone from the main map
3) With the patch there's issues with FoW maps

For example if there's an Irrigation both currently and in the FoW map, extra to add to FoW is determined by applying EC_IRRIGATE to real tile that already has Irrigation -> FoW map gets Farmland.
Other extras usually do not show at all since applying the extra cause to a real tile that already has the extra does nothing.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 07 Sep 2015 02:37:46 AM UTC, comment #1:

Still untested, but reading the savegame loading code, attached is a theoretical fix for the theoretical problem - will test practice before committing.

(file #25075, file #25076)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 26 Feb 2014 06:26:32 AM UTC, original submission:

I have not tested what happens, but loading old savegames with Mines on Deserts on rulesets where Oil Well is now used cannot work. I assume Mine will simply be discarded as illegal extra for Desert.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #25141:  SpecialToExtra-2.patch added by cazfi (11kB - text/x-diff)
file #25075:  SpecialToExtra.patch added by cazfi (4kB - text/x-diff)
file #25076:  SpecialToExtra-S2_6.patch added by cazfi (4kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 Sep 2015 06:07:10 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 13 Sep 2015 11:40:24 PM UTCcazfiAttached File-=>Added SpecialToExtra-2.patch, #25141
      Attached File-=>Added SpecialToExtra-S2_6-2.patch, #25142
      StatusIn Progress=>Ready For Test
    Wed 09 Sep 2015 06:45:52 PM UTCcazfiStatusReady For Test=>In Progress
    Mon 07 Sep 2015 02:37:46 AM UTCcazfiAttached File-=>Added SpecialToExtra.patch, #25075
      Attached File-=>Added SpecialToExtra-S2_6.patch, #25076
      StatusNone=>Ready For Test
      Planned Release2.6.0=>2.6.0, 3.0.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup