bugFreeciv - Bugs: bug #21726, Gtk3 Freeciv theme extremely slow

 
 
Show feedback again

bug #21726: Gtk3 Freeciv theme extremely slow

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 26 Feb 2014 07:32:29 PM UTC  
 
Category: client-gtk-3.0Severity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.3, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 13 Jun 2014 03:56:56 PM UTC, SVN revision 25135:

Reworked gtk3-client Freeciv theme to work around theme engine bug making it extremely slow.

See bug #21726

(Browse SVN revision 25135)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 12 Jun 2014 09:18:23 PM UTC, SVN revision 25129:

Reworked gtk3-client Freeciv theme to work around theme engine bug making it extremely slow.

See bug #21726

(Browse SVN revision 25129)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 12 Jun 2014 09:18:17 PM UTC, SVN revision 25128:

Reworked gtk3-client Freeciv theme to work around theme engine bug making it extremely slow.

See bug #21726

(Browse SVN revision 25128)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 12 Jun 2014 05:09:30 PM UTC, comment #5:

There's discussion about the theme engine bug that's probably causing our problems in the forums: http://forum.freeciv.org/f/viewtopic.php?f=8&t=317

I'm still about to commit the theme change. It doesn't hurt, and workaround in our own system helps end-users more than just saying that it's not our fault.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 08 Jun 2014 01:05:37 AM UTC, comment #4:

Apparently the "cover" property (stretching to fill entire widget) of background and notebook images was causing massive readjustments when ever screen was refresehed. It didn't help to remove either one of them, but getting rid of both fixed the issue.

Patch attached

- Background image now uses "round". That makes it still to fill the entire area, but it can repeat to do so.
- Notebook image has been replaced with gradient.

In addition to applying this patch one should remove Tabs/notebook.png as it's no longer needed.

(file #20965)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 07 Jun 2014 10:22:05 PM UTC, comment #3:

I just remembered that at around the same time (same gtk3 update) as slowness begun, freeciv theme started to work.

True enough, switching to another theme and restarting client, and everything is lightning fast.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 08 Mar 2014 05:09:09 PM UTC, comment #2:

patch #4590 helps somewhat, fixing the issue that move_unit_map_canvas() thinks framerate to be much higher than it really is and thus pushing too many frames out.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 08 Mar 2014 08:05:42 AM UTC, comment #1:

Having extra log messages written from animation loop in move_unit_map_canvas() shows that it proceeds with sensible speed. 20ms worth of logs appear in console immediately when unit moves, but then unit moves on-screen for a long time. Presumably it then draws one by one those frames move_unit_map_canvas() considered already drawn, and slowly.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 26 Feb 2014 07:32:29 PM UTC, original submission:

gtk3-client unit movement is now extremely slow. I don't see any recent commit as obvious suspect, so it can be something broken on my local system too.
gtk2-client not affected.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20965:  Gtk3ThemeNoCover.patch added by cazfi (1kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 12 Jun 2014 09:18:35 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 08 Jun 2014 01:05:37 AM UTCcazfiAttached File-=>Added Gtk3ThemeNoCover.patch, #20965
      StatusNone=>Ready For Test
      Planned Release=>2.4.3, 2.5.0, 2.6.0
      SummaryUnit movement extremely slow=>Gtk3 Freeciv theme extremely slow
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup