bugFreeciv - Bugs: bug #21744, Delegation is case-sensitive for...

 
 
Show feedback again

bug #21744: Delegation is case-sensitive for username

Submitted by:  Davide Baldini <davide_at_debian>
Submitted on:  Mon Mar 3 00:51:22 2014  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: 2.4.2Operating System: Any
Planned Release: 2.5.1, 2.6.0, 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed May 6 22:43:15 2015, SVN revision 29013:

Fixed delegation handling to be completely case-insensitive in respect to usernames.

Reported by Davide Baldini

See bug #21744

(Browse SVN revision 29013)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed May 6 22:43:06 2015, SVN revision 29012:

Fixed delegation handling to be completely case-insensitive in respect to usernames.

Reported by Davide Baldini

See bug #21744

(Browse SVN revision 29012)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed May 6 22:42:57 2015, SVN revision 29011:

Fixed delegation handling to be completely case-insensitive in respect to usernames.

Reported by Davide Baldini

See bug #21744

(Browse SVN revision 29011)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Apr 30 01:34:38 2015, comment #2:

Fix

(file #24403)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Apr 30 01:13:12 2015, comment #1:

Confirmed from connecthand.c that usernames are supposed to be case-insensitive (names differing only by case are considered duplicates).

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Mar 3 00:51:22 2014, original submission:

The current implementation of delegations is case-sensitive with regard to usernames. That is, if user "A" delegates his nation to user "B", "b" wouldn't be able to take the delegation from "A".

In Greatturn, games last for months and usernames can be somewhat long and complicated; sometimes users log-in typing their nicks w/o paying attention to case, and then they wonder why delegations stop working.

AFAIK, the whole structure of Freeciv is built to be case insensitive for usernames, so this patch, which comes from Longturn, is somewhat inconsistent. Moreover, Longturn solves this issue - for its sole benefit - by using the following custom code to internally handle delegations in interactions with DB:

I think this patch should be made consistent with the rest of Freeciv, by treating usernames case-insensitively.

Davide Baldini <davide_at_debian>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24403:  CaseInsensitiveDelegate.patch added by cazfi (1003B - text/plain-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by davide_at_debian (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed May 6 22:43:35 2015cazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu Apr 30 01:34:38 2015cazfiStatusNone=>Ready For Test
    Thu Apr 30 01:34:37 2015cazfiAttached File-=>Added CaseInsensitiveDelegate.patch, #24403
    Tue Apr 21 23:17:03 2015cazfiPlanned Release=>2.5.1, 2.6.0, 3.0.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup