bugBattle for Wesnoth - Bugs: bug #21759, timer refreshed too often when...

 
 
Show feedback again

bug #21759: timer refreshed too often when time runs out

Submitted by:  None
Submitted on:  Wed 05 Mar 2014 05:44:35 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Multiplayer
Status: FixedPrivacy: Public
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 1.11.11+dev
Operating System: All

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 05 Mar 2014 05:44:35 PM UTC, original submission:

When time runs out the timer bonus is given two times; even worse when there's still a random number coming from the server, timer bonus is given but the turn is not ended.
Can be fixed by removing lines 244-250 of playmp_controller.cpp
That code is duplicate of some code (after_human_turn, line 391, called by playsingle_controller.cpp line 677) that will be run if the turn ends in any way (unless player type changed, but I guess timer is not interesting at all in this case).

Duthlet

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by involution (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Apr 2014 12:51:46 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sun 30 Mar 2014 06:01:26 PM UTCinvolutionStatusNone=>Fixed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup