bugFreeciv - Bugs: bug #21803, Map canvas sliding after...

 
 
Show feedback again

bug #21803: Map canvas sliding after reconnecting

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 16 Mar 2014 12:35:32 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 16 Mar 2014 12:35:32 PM UTC, original submission:

I have not tried to setup actual test, but reading the sources...

Client remembers the old mapview canvas position so it can smoothly slide the view when new position is set. There's two exceptions:
- When client is first started, static variable "first" in center_tile_mapcanvas() tells that there's no old position to slide from
- set_mapview_scroll_pos() that's called for scroll bar handling disables sliding temporarily

Neither of these seem to handle the case of client to remembering position from the previous server when connecting new one. In theory this can result in at least unnecessary sliding from randomish position to the position game should start from. Worse things may happen if old server had bigger map than new one and the client remembers position outside new map boundaries.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup