bugFreeciv - Bugs: bug #21894, Crash in is_my_zoc()

 
 
Show feedback again

bug #21894: Crash in is_my_zoc()

Submitted by:  pepeto <pepeto>
Submitted on:  Sat 05 Apr 2014 10:15:08 AM UTC  
 
Category: generalSeverity: 4 - Important
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: trunk r24748Operating System: None
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 10 Apr 2014 11:00:57 PM UTC, comment #5:

No problem. Thanks for the fix; now committed.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Thu 10 Apr 2014 10:59:16 PM UTC, SVN revision 24754:

Fix crash in is_my_zoc() associated with unknown terrain.

Report and patch by pepeto (pepeto@gna).

See gna bug #21894.

(Browse SVN revision 24754)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Thu 10 Apr 2014 07:07:27 AM UTC, comment #3:

I cannot commit this before next week... That's why I didn't set it assigned to me.

pepeto <pepeto>
Project Member
Wed 09 Apr 2014 11:36:17 PM UTC, comment #2:

I consider this a critical bug fix patch, since it shows up almost immediately in many new games. Do you intend to commit it soon?

If I don't hear, I intend to commit this myself.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 05 Apr 2014 11:37:04 PM UTC, comment #1:

This crash shows up readily in a new game -- pressing 'G' on one of your first workers is often enough to provoke it, for me (I presume because there's plenty of unknown terrain around).

The attached patch makes the crash go away, for me.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 05 Apr 2014 10:15:08 AM UTC, original submission:

When trying a simple city attack, I experimented a segfault in is_my_zoc(). It looks like this has been added with the implementation of patch #4597.

Attached test savegame and a fix which works for me.

pepeto <pepeto>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20480:  is_my_zoc.diff added by pepeto (626B - text/x-diff)
file #20481:  freeciv-T0000-Y-4000-manual.sav.gz added by pepeto (23kB - application/x-gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 10 Apr 2014 11:00:57 PM UTCjtnStatusReady For Test=>Fixed
      Assigned toNone=>jtn
      Open/ClosedOpen=>Closed
    Sat 05 Apr 2014 10:15:08 AM UTCpepetoAttached File-=>Added is_my_zoc.diff, #20480
      Attached File-=>Added freeciv-T0000-Y-4000-manual.sav.gz, #20481
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup